Fix nested serializer validation for PATCH requests with {"id": X} format #682

New Issue

MrUnknownDE · 2026-04-05T17:09:17+02:00

MrUnknownDE commented

2026-04-05 17:09:17 +02:00

Originally created by @casibbald on 12/26/2025

When a nested serializer receives {"id": X} in a PATCH request, DRF was attempting to validate it as a full object, requiring all required fields (e.g., 'name' and 'group' for Tenant). This caused validation errors like 'group and name are required' even though the nested serializer should only look up the object by ID.

The fix overrides run_validation() to skip field-level validation for nested serializers, allowing to_internal_value() to properly handle {"id": X} format by looking up the object via get_related_object_by_attrs().

Fixes issue where PATCH requests to update Site with tenant field using {"id": X} format would fail with validation errors.

*Originally created by @casibbald on 12/26/2025* When a nested serializer receives {"id": X} in a PATCH request, DRF was attempting to validate it as a full object, requiring all required fields (e.g., 'name' and 'group' for Tenant). This caused validation errors like 'group and name are required' even though the nested serializer should only look up the object by ID. The fix overrides run_validation() to skip field-level validation for nested serializers, allowing to_internal_value() to properly handle {"id": X} format by looking up the object via get_related_object_by_attrs(). Fixes issue where PATCH requests to update Site with tenant field using {"id": X} format would fail with validation errors.

MrUnknownDE closed this issue

2026-04-05 17:09:17 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#682