Fixes #21064: Ensures that extra choices preserve nested colons #657

New Issue

MrUnknownDE · 2026-04-05T17:03:12+02:00

MrUnknownDE commented

2026-04-05 17:03:12 +02:00

Originally created by @jnovinger on 1/5/2026

Fixes: #21064

PR #14469 changed the separator from comma to colon. During review, Jeremy requested escape support, noting that colons would need escaping unlike commas. PR #14470 added the escape/unescape logic using the (?<!\\): regex pattern two days later. However, PR #18631 rewrote the __init__ method to fix #17796 (an IndexError when using "Create & Add Another") and inadvertently removed the re-escaping logic, leaving only the parsing side intact.

The fix is to re-escape colons in both value and label before joining them, ensuring proper round-trip handling when editing existing choice sets.

*Originally created by @jnovinger on 1/5/2026* ### Fixes: #21064 PR #14469 changed the separator from comma to colon. During review, Jeremy requested escape support, noting that colons would need escaping unlike commas. PR #14470 added the escape/unescape logic using the `(?<!\\):` regex pattern two days later. However, PR #18631 rewrote the `__init__` method to fix #17796 (an `IndexError` when using "Create & Add Another") and inadvertently removed the re-escaping logic, leaving only the parsing side intact. The fix is to re-escape colons in both value and label before joining them, ensuring proper round-trip handling when editing existing choice sets.

MrUnknownDE closed this issue

2026-04-05 17:03:12 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#657