Fixes: #19901

MrUnknownDE · 2026-04-05T17:02:16+02:00

MrUnknownDE commented

2026-04-05 17:02:16 +02:00

Originally created by @bctiemann on 1/7/2026

In the clean method of Module, we have a recursion check that presumes that the attribute module_bay has been set on the self object. If this attribute is missing, we throw a "Module has no module_bay" error, which is misleading and unhelpful.

This issue manifests when importing a module to a device that has no name, but this seems to be a red herring, as it can also occur on devices with names. It is a side effect of the recursion check not properly handling cases where module.module_bay is unset.

This change fixes the issue by skipping iterations in the recursion check where module.module_bay is unset.

Note that it does not directly address the reported issue in #19901, that an error is thrown when bulk-importing Modules to a Device whose name is null. For these cases, the workaround (and expected usage) is to use device.id as the bulk import field rather than the name; and with this fix a more helpful snackbar validation error is produced instead of an unhandled Server Error:

*Originally created by @bctiemann on 1/7/2026* ### Fixes: #19901 In the `clean` method of `Module`, we have a recursion check that presumes that the attribute `module_bay` has been set on the `self` object. If this attribute is missing, we throw a "Module has no module_bay" error, which is misleading and unhelpful. This issue manifests when importing a module to a device that has no name, but this seems to be a red herring, as it can also occur on devices with names. It is a side effect of the recursion check not properly handling cases where `module.module_bay` is unset. This change fixes the issue by skipping iterations in the recursion check where `module.module_bay` is unset. **Note** that it does not directly address the reported issue in #19901, that an error is thrown when bulk-importing Modules to a Device whose name is null. For these cases, the workaround (and expected usage) is to use `device.id` as the bulk import field rather than the name; and with this fix a more helpful snackbar validation error is produced instead of an unhandled Server Error: <img width="880" height="750" alt="Screenshot 2026-01-06 at 10 01 53 PM" src="https://github.com/user-attachments/assets/7ae539d3-8d24-4140-8c78-5f1b9a8c48cd" />

MrUnknownDE closed this issue

2026-04-05 17:02:16 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#648