Fixes #20239: Prevent shared mutable state in PluginMenuItem/PluginMenuButton #633

New Issue

MrUnknownDE · 2026-04-05T16:58:05+02:00

MrUnknownDE commented

2026-04-05 16:58:05 +02:00

Originally created by @jnovinger on 1/8/2026

Fixes: #20239

PluginMenuItem and PluginMenuButton classes used mutable class-level defaults for permissions and buttons attributes, causing permission leakage between instances when these attributes were modified without explicit parameters.

Changed to initialize these attributes as fresh lists per instance in __init__ when not explicitly provided, following standard Python pattern for avoiding mutable default arguments.

*Originally created by @jnovinger on 1/8/2026* ### Fixes: #20239 `PluginMenuItem` and `PluginMenuButton` classes used mutable class-level defaults for `permissions` and `buttons` attributes, causing permission leakage between instances when these attributes were modified without explicit parameters. Changed to initialize these attributes as fresh lists per instance in `__init__` when not explicitly provided, following standard Python pattern for avoiding mutable default arguments.

MrUnknownDE closed this issue

2026-04-05 16:58:05 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#633