20911 Fix sorting in dropdown #631

New Issue

MrUnknownDE · 2026-04-05T16:58:05+02:00

MrUnknownDE commented

2026-04-05 16:58:05 +02:00

Originally created by @arthanson on 1/9/2026

Fixes: #20911

Two issues:

The sorting order wasn't alphabetical
Even with corrected sorting order, the selected item was show in the wrong ordering in the list (i.e. When you install a module into a Module Bay the select has a pre-set Module-bay, but when you do the dropdown - this pre-selected item shows up in the wrong order in the dropdown).

This fixes item 1, item 2 still appears but would need a front-end fix so keeping that for a separate ticket.

As noted in the issue discussion, the change to order_insertion_by will fix the ordering of newly inserted items, there were other ordering problems in bulk edit and bulk rename which this also fixes. I tried either looping and doing a save or doing a bulk_update and then a rebuild at the end, for small data-sets the bulk_update if much faster, for large data-sets they are almost the same perf but bulk_update still wins out.

Just changing order_insertion_by revealed an existing bug in the CSV import when using the order_insertion_by. We don't run into it in the tests for NestedGroupModel (the other model using it) because of the way the imports are ordered in the test case as they don't cause a re-arrangement in the tree. The ordering of the ModuleBay test actually does cause a re-ordering and hits what looks like a bug in MPTT code. The additional changes in bulk_views.py so the CSV processing if done on models that inherit form MPTTModel uses a delay_mptt_updates() and rebuild at the end fixes this issue.

*Originally created by @arthanson on 1/9/2026* ### Fixes: #20911 Two issues: 1. The sorting order wasn't alphabetical 2. Even with corrected sorting order, the selected item was show in the wrong ordering in the list (i.e. When you install a module into a Module Bay the select has a pre-set Module-bay, but when you do the dropdown - this pre-selected item shows up in the wrong order in the dropdown). This fixes item 1, item 2 still appears but would need a front-end fix so keeping that for a separate ticket. As noted in the issue discussion, the change to order_insertion_by will fix the ordering of newly inserted items, there were other ordering problems in bulk edit and bulk rename which this also fixes. I tried either looping and doing a save or doing a bulk_update and then a rebuild at the end, for small data-sets the bulk_update if much faster, for large data-sets they are almost the same perf but bulk_update still wins out. Just changing order_insertion_by revealed an existing bug in the CSV import when using the order_insertion_by. We don't run into it in the tests for NestedGroupModel (the other model using it) because of the way the imports are ordered in the test case as they don't cause a re-arrangement in the tree. The ordering of the ModuleBay test actually does cause a re-ordering and hits what looks like a bug in MPTT code. The additional changes in bulk_views.py so the CSV processing if done on models that inherit form MPTTModel uses a delay_mptt_updates() and rebuild at the end fixes this issue.

MrUnknownDE closed this issue

2026-04-05 16:58:05 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#631