Fixes #21213: Make Tag weight field required in forms #531

New Issue

MrUnknownDE · 2026-04-05T16:40:23+02:00

MrUnknownDE commented

2026-04-05 16:40:23 +02:00

Originally created by @adionit7 on 1/19/2026

The weight field was explicitly declared with required=False in TagForm and TagImportForm, allowing empty submissions that would crash with a database IntegrityError since the column is NOT NULL.

By removing the explicit field override, Django now auto-generates the form field from the model, which has default=1000 and is required. This ensures the UI matches the database constraint and prevents invalid submissions before they reach the database.

Fixes: #21213

Summary

Remove the explicit weight field overrides from TagForm and TagImportForm that set required=False.
Allow Django to use the model’s PositiveSmallIntegerField(default=1000) directly, making the field required at the form level.
Align form validation with the database NOT NULL constraint to avoid IntegrityError when the weight is left empty.

*Originally created by @adionit7 on 1/19/2026* The weight field was explicitly declared with `required=False` in `TagForm` and `TagImportForm`, allowing empty submissions that would crash with a database `IntegrityError` since the column is `NOT NULL`. By removing the explicit field override, Django now auto-generates the form field from the model, which has `default=1000` and is required. This ensures the UI matches the database constraint and prevents invalid submissions before they reach the database.  ### Fixes: #21213  ### Summary - Remove the explicit `weight` field overrides from `TagForm` and `TagImportForm` that set `required=False`. - Allow Django to use the model’s `PositiveSmallIntegerField(default=1000)` directly, making the field required at the form level. - Align form validation with the database `NOT NULL` constraint to avoid `IntegrityError` when the weight is left empty.

MrUnknownDE closed this issue

2026-04-05 16:40:23 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#531