Fixes #21214: Clean up AutoSyncRecord when detaching from DataSource #530

New Issue

MrUnknownDE · 2026-04-05T16:40:23+02:00

MrUnknownDE commented

2026-04-05 16:40:23 +02:00

Originally created by @adionit7 on 1/19/2026

When a synced object (e.g., ConfigTemplate) is detached from a DataSource, the clean() method sets data_file to None before save() is called. The previous code attempted to delete the AutoSyncRecord by filtering with datafile=self.data_file, which in this case is None, so it never matched the existing record and left a stale AutoSyncRecord behind.

This caused subsequent DataSource sync jobs to fail when trying to sync objects that no longer had a valid data_file. The fix removes the datafile filter from the delete query and relies on the existing UniqueConstraint on (object_type, object_id) to correctly identify and delete the associated AutoSyncRecord.

Fixes: #21214

Summary

Update SyncedDataMixin.save() and .delete() to delete AutoSyncRecord instances by (object_type, object_id) only.
Remove the datafile=self.data_file filter, which could be None after clean() has cleared data_file when detaching from a DataSource.
Ensure that stale AutoSyncRecord rows are cleaned up when a synced object is detached, allowing subsequent DataSource syncs to proceed without errors.

*Originally created by @adionit7 on 1/19/2026* When a synced object (e.g., `ConfigTemplate`) is detached from a `DataSource`, the `clean()` method sets `data_file` to `None` before `save()` is called. The previous code attempted to delete the `AutoSyncRecord` by filtering with `datafile=self.data_file`, which in this case is `None`, so it never matched the existing record and left a stale `AutoSyncRecord` behind. This caused subsequent DataSource sync jobs to fail when trying to sync objects that no longer had a valid `data_file`. The fix removes the `datafile` filter from the delete query and relies on the existing `UniqueConstraint` on `(object_type, object_id)` to correctly identify and delete the associated `AutoSyncRecord`.  ### Fixes: #21214  ### Summary - Update `SyncedDataMixin.save()` and `.delete()` to delete `AutoSyncRecord` instances by `(object_type, object_id)` only. - Remove the `datafile=self.data_file` filter, which could be `None` after `clean()` has cleared `data_file` when detaching from a `DataSource`. - Ensure that stale `AutoSyncRecord` rows are cleaned up when a synced object is detached, allowing subsequent DataSource syncs to proceed without errors.

MrUnknownDE closed this issue

2026-04-05 16:40:23 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#530