Fixes #21160: Handle "null" choice selection in widgets #514

New Issue

MrUnknownDE · 2026-04-05T16:38:50+02:00

MrUnknownDE commented

2026-04-05 16:38:50 +02:00

Originally created by @pheus on 1/20/2026

Fixes: #21160

This PR addresses a regression introduced by the performance changes in #21200: selecting the “None”/null tenant option (e.g. tenant_id=null) could raise Field 'id' expected a number but got 'null' during widget rendering.

The widget now filters out the null sentinel before querying for selected PKs, while still preserving the “None” option in the rendered select (including mixed selections like [<pk>, null]). Regression tests have been added to cover both the null-only and mixed-selection cases.

Thanks to everyone who worked on the performance improvements! This is a small follow-up to keep the previous filtering behavior intact. 🙏

*Originally created by @pheus on 1/20/2026* ### Fixes: #21160 This PR addresses a regression introduced by the performance changes in #21200: selecting the **“None”/null** tenant option (e.g. `tenant_id=null`) could raise `Field 'id' expected a number but got 'null'` during widget rendering. The widget now filters out the null sentinel before querying for selected PKs, while still preserving the “None” option in the rendered select (including mixed selections like `[<pk>, null]`). Regression tests have been added to cover both the null-only and mixed-selection cases. Thanks to everyone who worked on the performance improvements! This is a small follow-up to keep the previous filtering behavior intact. 🙏

MrUnknownDE closed this issue

2026-04-05 16:38:50 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#514