Fixes #21115: Include attribute_data in ModuleType YAML export #508

New Issue

MrUnknownDE · 2026-04-05T16:37:59+02:00

MrUnknownDE commented

2026-04-05 16:37:59 +02:00

Originally created by @adionit7 on 1/21/2026

Summary

This PR fixes an issue where custom JSON properties defined in module type profiles were not being included in YAML exports of module types. The to_yaml() method was missing both the airflow field and the attribute_data field which contains the custom properties.

Changes Made

Added airflow field to ModuleType.to_yaml() method
Added attribute_data field to ModuleType.to_yaml() method

Problem

When exporting a module type with custom properties defined via a module type profile schema (e.g., u_generation in the example from the issue), these properties were not included in the YAML export output, even though they were properly stored in the attribute_data JSONField.

Solution

The fix adds both missing fields to the YAML export:

airflow: The airflow direction field (consistent with how DeviceType.to_yaml() handles it)
attribute_data: The JSON field containing all custom properties from the profile schema

This ensures complete round-trip export/import functionality, as ModuleTypeImportForm already supports importing attribute_data.

Testing

Verified that attribute_data is properly exported in YAML format
Confirmed consistency with existing DeviceType.to_yaml() implementation
Ensured compatibility with existing import functionality

*Originally created by @adionit7 on 1/21/2026* Fixes #21115 ## Summary This PR fixes an issue where custom JSON properties defined in module type profiles were not being included in YAML exports of module types. The `to_yaml()` method was missing both the `airflow` field and the `attribute_data` field which contains the custom properties. ## Changes Made - Added `airflow` field to `ModuleType.to_yaml()` method - Added `attribute_data` field to `ModuleType.to_yaml()` method ## Problem When exporting a module type with custom properties defined via a module type profile schema (e.g., `u_generation` in the example from the issue), these properties were not included in the YAML export output, even though they were properly stored in the `attribute_data` JSONField. ## Solution The fix adds both missing fields to the YAML export: - `airflow`: The airflow direction field (consistent with how `DeviceType.to_yaml()` handles it) - `attribute_data`: The JSON field containing all custom properties from the profile schema This ensures complete round-trip export/import functionality, as `ModuleTypeImportForm` already supports importing `attribute_data`. ## Testing - Verified that `attribute_data` is properly exported in YAML format - Confirmed consistency with existing `DeviceType.to_yaml()` implementation - Ensured compatibility with existing import functionality

MrUnknownDE closed this issue

2026-04-05 16:37:59 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#508