Fixes #21202: Fix scoped form cloning clearing the Scope field when Scope Type changes #491

New Issue

MrUnknownDE · 2026-04-05T16:36:28+02:00

MrUnknownDE commented

2026-04-05 16:36:28 +02:00

Originally created by @pheus on 1/22/2026

Fixes: #21202

This PR adjusts ScopedForm._set_scoped_values() so it no longer clears initial['scope'] during clone form initialization.

Previously, when cloning an object with scoped fields (e.g., a Prefix scoped to Site: DC1), the form would treat the scope_type mismatch like an edit and wipe the pre-filled scope on the initial GET, forcing the user to re-select it manually.

With this change, the scope is only cleared when editing an existing object (instance.pk is set) and the scope_type has actually changed.

Thanks for taking a look! This also helps unblock the follow-up fix in #21262.

*Originally created by @pheus on 1/22/2026* ### Fixes: #21202 This PR adjusts `ScopedForm._set_scoped_values()` so it no longer clears `initial['scope']` during clone form initialization. Previously, when cloning an object with scoped fields (e.g., a Prefix scoped to `Site: DC1`), the form would treat the `scope_type` mismatch like an edit and wipe the pre-filled scope on the initial GET, forcing the user to re-select it manually. With this change, the scope is only cleared when **editing an existing object** (`instance.pk` is set) *and* the `scope_type` has actually changed. Thanks for taking a look! This also helps unblock the follow-up fix in #21262.

MrUnknownDE closed this issue

2026-04-05 16:36:29 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#491