Fixes #21242: Show Authentication admin menu items based on object perms #475

New Issue

MrUnknownDE · 2026-04-05T16:34:52+02:00

MrUnknownDE commented

2026-04-05 16:34:52 +02:00

Originally created by @pheus on 1/23/2026

Fixes: #21242

This PR adjusts the Admin → Authentication menu items to follow the usual object-permission checks again (instead of being gated behind staff_only).

Concretely, it replaces the hardcoded menu definitions for Users, Groups, API Tokens, and Permissions with get_model_item(). This removes the staff_only restriction for these items and relies on the standard view_*/add_* permissions and button actions provided by the helper.

This aligns with the intent discussed in #21242: System items remain superuser-only, while Authentication items should be available to non-superusers when they have the relevant permissions. Thanks to the maintainers for the clarification and guidance on the expected behavior.

*Originally created by @pheus on 1/23/2026*  ### Fixes: #21242  This PR adjusts the Admin → Authentication menu items to follow the usual object-permission checks again (instead of being gated behind `staff_only`). Concretely, it replaces the hardcoded menu definitions for **Users**, **Groups**, **API Tokens**, and **Permissions** with `get_model_item()`. This removes the `staff_only` restriction for these items and relies on the standard `view_*`/`add_*` permissions and button actions provided by the helper. This aligns with the intent discussed in #21242: **System** items remain superuser-only, while **Authentication** items should be available to non-superusers when they have the relevant permissions. Thanks to the maintainers for the clarification and guidance on the expected behavior.

MrUnknownDE closed this issue

2026-04-05 16:34:52 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#475