Fixes #21269: Fix Module installation to replicate Front/Rear Port Mappings from Module Types #458

New Issue

MrUnknownDE · 2026-04-05T16:33:50+02:00

MrUnknownDE commented

2026-04-05 16:33:50 +02:00

Originally created by @pheus on 1/27/2026

Fixes: #21269

This PR fixes an issue where front-to-rear port mappings defined on a ModuleType were not carried over when installing the module into a device’s ModuleBay.

When a module is installed, NetBox now correctly replicates the template port mappings into PortMapping instances on the resulting module’s ports, preserving positions and ensuring the expected front/rear relationships (e.g., splice cassettes).

To prevent regressions, this PR also adds coverage to ModuleBayTestCase verifying that:

installing a module with template mappings creates the expected PortMapping records, and
installing a module without template mappings does not create any mappings.

Thanks for the review!

*Originally created by @pheus on 1/27/2026* ### Fixes: #21269 This PR fixes an issue where front-to-rear port mappings defined on a `ModuleType` were not carried over when installing the module into a device’s `ModuleBay`. When a module is installed, NetBox now correctly replicates the template port mappings into `PortMapping` instances on the resulting module’s ports, preserving positions and ensuring the expected front/rear relationships (e.g., splice cassettes). To prevent regressions, this PR also adds coverage to `ModuleBayTestCase` verifying that: - installing a module with template mappings creates the expected `PortMapping` records, and - installing a module without template mappings does not create any mappings. Thanks for the review!

MrUnknownDE closed this issue

2026-04-05 16:33:50 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#458