Fixes #21320: Prevent Rack validation errors when site or optional fields are missing during import #449

New Issue

MrUnknownDE · 2026-04-05T16:33:16+02:00

MrUnknownDE commented

2026-04-05 16:33:16 +02:00

Originally created by @pheus on 1/29/2026

Fixes: #21320

This PR prevents an uncaught exception during Rack direct import/validation when the site relation isn’t set (e.g. due to missing/incorrect CSV headers), which previously could raise RelatedObjectDoesNotExist.

Summary of changes

Update Rack validation to use the FK ID fields (site_id / location_id) instead of accessing related objects directly.
Avoid triggering related-object lookups during validation, ensuring we return normal, user-facing validation errors rather than a backend exception.
Aligns the validation logic with Django’s underlying foreign key fields and behavior when relations are unset.

Thanks again to @cpt-kernel-afk for the report and sample CSVs, and to @jnovinger for the review/suggestion to use FK IDs here.

*Originally created by @pheus on 1/29/2026* ### Fixes: #21320 This PR prevents an uncaught exception during Rack direct import/validation when the `site` relation isn’t set (e.g. due to missing/incorrect CSV headers), which previously could raise `RelatedObjectDoesNotExist`. #### Summary of changes - Update Rack validation to use the FK ID fields (`site_id` / `location_id`) instead of accessing related objects directly. - Avoid triggering related-object lookups during validation, ensuring we return normal, user-facing validation errors rather than a backend exception. - Aligns the validation logic with Django’s underlying foreign key fields and behavior when relations are unset. Thanks again to @cpt-kernel-afk for the report and sample CSVs, and to @jnovinger for the review/suggestion to use FK IDs here.

MrUnknownDE closed this issue

2026-04-05 16:33:16 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#449