Closes #21201: Support GenericForeignKey fields when cloning objects #446

New Issue

MrUnknownDE · 2026-04-05T16:33:08+02:00

MrUnknownDE commented

2026-04-05 16:33:08 +02:00

Originally created by @pheus on 1/29/2026

Fixes: #21201

This PR improves cloning support for models that use GenericForeignKey (GFK) fields.

Problem

When cloning an object, CloningMixin.clone() currently copies only the underlying database fields (e.g. <name>_type and <name>_id). In the UI, however, NetBox forms typically expose a single combined DynamicModelChoiceField named after the GFK attribute (e.g. parent, scope). As a result, the selector field is not pre-populated during cloning even though the CT+ID values are present in the URL parameters.

Changes

Enhance CloningMixin.clone() to detect GenericForeignKey fields and, when both the content type field and ID field are included in clone_fields, inject the GFK attribute name into the returned clone dict (unless already set).
Add tests covering:
- successful injection when both constituent fields are present
- no injection when only one constituent field is present

Result

Cloning now pre-populates form fields backed by GenericForeignKey consistently across the UI without requiring model- or form-specific overrides.

Thanks for reviewing!

*Originally created by @pheus on 1/29/2026* ### Fixes: #21201 This PR improves cloning support for models that use **GenericForeignKey (GFK)** fields. #### Problem When cloning an object, `CloningMixin.clone()` currently copies only the underlying database fields (e.g. `<name>_type` and `<name>_id`). In the UI, however, NetBox forms typically expose a single combined `DynamicModelChoiceField` named after the GFK attribute (e.g. `parent`, `scope`). As a result, the selector field is not pre-populated during cloning even though the CT+ID values are present in the URL parameters. #### Changes - Enhance `CloningMixin.clone()` to detect `GenericForeignKey` fields and, **when both the content type field and ID field are included in `clone_fields`**, inject the GFK attribute name into the returned clone dict (unless already set). - Add tests covering: - successful injection when both constituent fields are present - no injection when only one constituent field is present #### Result Cloning now pre-populates form fields backed by `GenericForeignKey` consistently across the UI without requiring model- or form-specific overrides. Thanks for reviewing!

MrUnknownDE closed this issue

2026-04-05 16:33:08 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#446