Expand unit tests for ObjectChange and testing asserts #415

New Issue

MrUnknownDE · 2026-04-05T16:30:52+02:00

MrUnknownDE commented

2026-04-05 16:30:52 +02:00

Originally created by @arthanson on 2/5/2026

NetBox version

v4.5.2

Feature type

Other

Proposed functionality

Currently there are some basic tests for ObjectChange records in netbox/utilities/testing/views.py these are run for all models, however they only test that an ObjectChange was created (or deleted) and don't test several critical pieces of functionality like prechange and postchange data.

This FR is to look at adding tests to these for checking prechange and postchange data where possible, or expanding the tests so that tests can be done that a single ObjectChange is created and that the prechange and postchange data match what was expected.

It would also probably be beneficial to add specific assert functions specific to ObjectChange something like assert_prechange_data_equals or such that can be used in tests.

Use case

ObjectChange handling is central to NetBox and netbox-branching is completely driven off of it, so it is critical that it works correctly and it thoroughly tested. There have also been several very serious bugs in netbox-branching due to errors in incorrectly created ObjectChange records. There are some basic tests for all models in netbox/utilities/testing/views.py and these could be fairly easily expanded.

Database changes

N/A

External dependencies

N/A

*Originally created by @arthanson on 2/5/2026* ### NetBox version v4.5.2 ### Feature type Other ### Proposed functionality Currently there are some basic tests for ObjectChange records in `netbox/utilities/testing/views.py` these are run for all models, however they only test that an ObjectChange was created (or deleted) and don't test several critical pieces of functionality like prechange and postchange data. This FR is to look at adding tests to these for checking prechange and postchange data where possible, or expanding the tests so that tests can be done that a single ObjectChange is created and that the prechange and postchange data match what was expected. It would also probably be beneficial to add specific assert functions specific to ObjectChange something like assert_prechange_data_equals or such that can be used in tests. ### Use case ObjectChange handling is central to NetBox and netbox-branching is completely driven off of it, so it is critical that it works correctly and it thoroughly tested. There have also been several very serious bugs in netbox-branching due to errors in incorrectly created ObjectChange records. There are some basic tests for all models in `netbox/utilities/testing/views.py` and these could be fairly easily expanded. ### Database changes N/A ### External dependencies N/A

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox status: backlog status: backlog status: backlog status: backlog status: backlog status: backlog status: backlog status: backlog status: backlog status: backlog status: backlog status: backlog topic: testing type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature type: feature

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#415