Closes #20981: Enhance JSON rendering for Custom Validators and Protection Rules in Config Revision View #403

New Issue

MrUnknownDE · 2026-04-05T16:29:54+02:00

MrUnknownDE commented

2026-04-05 16:29:54 +02:00

Originally created by @pheus on 2/6/2026

Fixes: #20981

This PR harmonizes how JSON-like configuration values are displayed in the configuration revision UI.

ConfigRevisionView.get_extra_context() now prepares a safe, pretty-printed JSON representation for CUSTOM_VALIDATORS, DEFAULT_USER_PREFERENCES and PROTECTION_RULES before rendering config_data.html. This mirrors the behavior users already see in the global system configuration view and makes these fields consistently readable in the config history view.

Thanks for the review!

*Originally created by @pheus on 2/6/2026* ### Fixes: #20981 This PR harmonizes how JSON-like configuration values are displayed in the configuration revision UI. `ConfigRevisionView.get_extra_context()` now prepares a safe, pretty-printed JSON representation for `CUSTOM_VALIDATORS`, `DEFAULT_USER_PREFERENCES` and `PROTECTION_RULES` before rendering `config_data.html`. This mirrors the behavior users already see in the global system configuration view and makes these fields consistently readable in the config history view. Thanks for the review!

MrUnknownDE closed this issue

2026-04-05 16:29:54 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#403