Fixes #21375: Fix VLANGroup VLAN ID range migration failing on upgrades with existing data #401

New Issue

MrUnknownDE · 2026-04-05T16:29:54+02:00

MrUnknownDE commented

2026-04-05 16:29:54 +02:00

Originally created by @pheus on 2/6/2026

Fixes: #21375

This PR updates the ipam/migrations/0070_vlangroup_vlan_id_ranges.py data migration to avoid calling save() for each existing VLANGroup. Instead, it calculates the VLAN ID ranges and applies the changes via bulk_update().

Using bulk_update() prevents post_save handlers (notably the search cache/indexing hooks) from running during the migration, which can otherwise raise an AttributeError on instances lacking a comments attribute and abort the upgrade. It also limits the update to only the relevant fields and performs better on larger databases with many VLANGroup rows.

Appreciate your time reviewing this!

*Originally created by @pheus on 2/6/2026* ### Fixes: #21375 This PR updates the `ipam/migrations/0070_vlangroup_vlan_id_ranges.py` data migration to avoid calling `save()` for each existing `VLANGroup`. Instead, it calculates the VLAN ID ranges and applies the changes via `bulk_update()`. Using `bulk_update()` prevents `post_save` handlers (notably the search cache/indexing hooks) from running during the migration, which can otherwise raise an `AttributeError` on instances lacking a `comments` attribute and abort the upgrade. It also limits the update to only the relevant fields and performs better on larger databases with many `VLANGroup` rows. Appreciate your time reviewing this!

MrUnknownDE closed this issue

2026-04-05 16:29:54 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#401