Fixes #21358: Prevent exception when sorting by Token column #390

New Issue

MrUnknownDE · 2026-04-05T16:29:01+02:00

MrUnknownDE commented

2026-04-05 16:29:01 +02:00

Originally created by @adionit7 on 2/10/2026

Fixes

Closes #21358

Summary

Clicking the "Token" column header in the API Tokens table triggers a FieldError because token is a Python property on the model, not a database field. django-tables2 attempts to pass it to Django's ORM order_by(), which fails.

Changes:

Mark the token TemplateColumn in TokenTable as orderable=False, consistent with how other non-field columns are handled in the codebase (e.g. can_view, can_add, can_change, can_delete in ObjectPermissionTable)
Add a regression test for TokenTable that verifies all orderable columns can be sorted without raising exceptions, following the existing pattern in circuits/tests/test_tables.py and vpn/tests/test_tables.py

*Originally created by @adionit7 on 2/10/2026* ## Fixes Closes #21358 ## Summary Clicking the "Token" column header in the API Tokens table triggers a `FieldError` because `token` is a Python property on the model, not a database field. django-tables2 attempts to pass it to Django's ORM `order_by()`, which fails. **Changes:** - Mark the `token` `TemplateColumn` in `TokenTable` as `orderable=False`, consistent with how other non-field columns are handled in the codebase (e.g. `can_view`, `can_add`, `can_change`, `can_delete` in `ObjectPermissionTable`) - Add a regression test for `TokenTable` that verifies all orderable columns can be sorted without raising exceptions, following the existing pattern in `circuits/tests/test_tables.py` and `vpn/tests/test_tables.py`

MrUnknownDE closed this issue

2026-04-05 16:29:01 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#390