Fixes #21371: Fix Webhook Event Rules for Job lifecycle events missing username #342

New Issue

MrUnknownDE · 2026-04-05T16:26:42+02:00

MrUnknownDE commented

2026-04-05 16:26:42 +02:00

Originally created by @pheus on 2/16/2026

Fixes: #21371

This PR fixes webhook event rule processing for job lifecycle events (e.g. scripts) when the event context does not include the legacy username attribute. In these cases, webhook enqueueing raised a KeyError and incorrectly caused the job to be marked as errored, preventing the webhook from being sent.

Changes included:

Derive username from the associated user object when event["username"] is not present (maintaining backward compatibility for request-based events).
Add a regression test covering JOB_COMPLETED for extras.script to ensure a webhook is enqueued successfully when no request/legacy attributes are available.

Thanks for the review!

*Originally created by @pheus on 2/16/2026* ### Fixes: #21371 This PR fixes webhook event rule processing for **job lifecycle events** (e.g. scripts) when the event context does not include the legacy `username` attribute. In these cases, webhook enqueueing raised a `KeyError` and incorrectly caused the job to be marked as errored, preventing the webhook from being sent. **Changes included:** - Derive `username` from the associated `user` object when `event["username"]` is not present (maintaining backward compatibility for request-based events). - Add a regression test covering `JOB_COMPLETED` for `extras.script` to ensure a webhook is enqueued successfully when no request/legacy attributes are available. Thanks for the review!

MrUnknownDE closed this issue

2026-04-05 16:26:42 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#342