Fixes #21429: Add Cable cloning and fix "Create & Add Another" to preserve Termination Types #337

New Issue

MrUnknownDE · 2026-04-05T16:26:33+02:00

MrUnknownDE commented

2026-04-05 16:26:33 +02:00

Originally created by @pheus on 2/17/2026

Fixes: #21429

This PR fixes the “Create & Add Another” workflow for cables by ensuring the selected termination types are preserved.

To do this, it extends Cable.clone() to include the form-only fields required by get_cable_form() (termination type and the relevant parent selector fields for each end). This makes both “Clone” and “Create & Add Another” behave consistently, while intentionally not cloning the actual terminations (since those endpoints are already occupied).

I’ve added a small note in get_cable_form() to document that Cable.clone() mirrors its parent selector mapping to help keep these in sync going forward.
Thanks for reviewing!

*Originally created by @pheus on 2/17/2026* ### Fixes: #21429 This PR fixes the “Create & Add Another” workflow for cables by ensuring the selected termination types are preserved. To do this, it extends `Cable.clone()` to include the form-only fields required by `get_cable_form()` (termination type and the relevant parent selector fields for each end). This makes both **“Clone”** and **“Create & Add Another”** behave consistently, while intentionally **not** cloning the actual terminations (since those endpoints are already occupied). I’ve added a small note in `get_cable_form()` to document that `Cable.clone()` mirrors its parent selector mapping to help keep these in sync going forward. Thanks for reviewing!

MrUnknownDE closed this issue

2026-04-05 16:26:33 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#337