Fixes #21407: Enable Ruff isort rules for consistent import ordering #333

New Issue

MrUnknownDE · 2026-04-05T16:26:21+02:00

MrUnknownDE commented

2026-04-05 16:26:21 +02:00

Originally created by @pheus on 2/17/2026

Fixes: #21407

This PR enables Ruff’s I (isort) rules to standardize import ordering across the codebase.

Adopt Ruff I (isort) rules for consistent import sorting
Update a few imports to use relative imports within their Django apps to avoid circular-import issues exposed by sorting
Add two # isort: split boundaries to keep required imports pinned in order-dependent __init__.py modules

For easier review, the only manual edits are in:

ruff.toml
netbox/netbox/api/serializers/__init__.py
netbox/core/models/__init__.py

Thanks for reviewing! The changes should be purely stylistic/organizational with no intended runtime behavior changes beyond stabilizing import initialization order.

*Originally created by @pheus on 2/17/2026* ### Fixes: #21407 This PR enables Ruff’s `I` (isort) rules to standardize import ordering across the codebase. - Adopt Ruff `I` (isort) rules for consistent import sorting - Update a few imports to use relative imports within their Django apps to avoid circular-import issues exposed by sorting - Add two `# isort: split` boundaries to keep required imports pinned in order-dependent `__init__.py` modules For easier review, the only manual edits are in: - `ruff.toml` - `netbox/netbox/api/serializers/__init__.py` - `netbox/core/models/__init__.py` Thanks for reviewing! The changes should be purely stylistic/organizational with no intended runtime behavior changes beyond stabilizing import initialization order.

MrUnknownDE closed this issue

2026-04-05 16:26:21 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#333