GraphQL union type resolution for connected endpoints uses ConsolePortType instead of ConsolePort #317

New Issue

MrUnknownDE · 2026-04-05T16:25:41+02:00

MrUnknownDE commented

2026-04-05 16:25:41 +02:00

Originally created by @pheus on 2/18/2026

NetBox Edition

NetBox Community

NetBox Version

v4.5.3

Python Version

3.12

Steps to Reproduce

Create a Console Port (any device, any name is fine).
Open a Django shell (python manage.py shell).

Run:

from dcim.models import ConsolePort
from dcim.graphql.gfk_mixins import ConnectedEndpointType

port = ConsolePort.objects.first()
ConnectedEndpointType.resolve_type(port, None)

Expected Behavior

ConnectedEndpointType.resolve_type() should return ConsolePortType for a ConsolePort model instance (consistent with the other branches and with InventoryItemComponentType.resolve_type() in the same module).

Observed Behavior

The method returns None for ConsolePort instances because it currently checks against the GraphQL type class:

# netbox/dcim/graphql/gfk_mixins.py
if type(instance) is ConsolePortType:
    return ConsolePortType

This means the ConsolePort branch is never taken, and union resolution relies on Strawberry’s fallback behavior. In my testing, the GraphQL query still happens to return ConsolePortType either way, but the resolver logic itself is incorrect/inconsistent and seems easy to trip up with future changes.

Proposed fix
Change the check to:

if type(instance) is ConsolePort:
    return ConsolePortType

*Originally created by @pheus on 2/18/2026* ### NetBox Edition NetBox Community ### NetBox Version v4.5.3 ### Python Version 3.12 ### Steps to Reproduce 1. Create a **Console Port** (any device, any name is fine). 2. Open a Django shell (`python manage.py shell`). 3. Run: ```python from dcim.models import ConsolePort from dcim.graphql.gfk_mixins import ConnectedEndpointType port = ConsolePort.objects.first() ConnectedEndpointType.resolve_type(port, None) ``` ### Expected Behavior `ConnectedEndpointType.resolve_type()` should return `ConsolePortType` for a `ConsolePort` model instance (consistent with the other branches and with `InventoryItemComponentType.resolve_type()` in the same module). ### Observed Behavior The method returns `None` for `ConsolePort` instances because it currently checks against the GraphQL type class: ```python # netbox/dcim/graphql/gfk_mixins.py if type(instance) is ConsolePortType: return ConsolePortType ``` This means the ConsolePort branch is never taken, and union resolution relies on Strawberry’s fallback behavior. In my testing, the GraphQL query still *happens* to return `ConsolePortType` either way, but the resolver logic itself is incorrect/inconsistent and seems easy to trip up with future changes. **Proposed fix** Change the check to: ```python if type(instance) is ConsolePort: return ConsolePortType ```

MrUnknownDE closed this issue

2026-04-05 16:25:41 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low severity: low status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#317

GraphQL union type resolution for connected endpoints uses ConsolePortType instead of ConsolePort #317