Enable linting for __all__ ordering (RUF022) #299

New Issue

MrUnknownDE · 2026-04-05T16:25:03+02:00

MrUnknownDE commented

2026-04-05 16:25:03 +02:00

Originally created by @jeremystretch on 2/20/2026

Proposed Changes

Enable Ruff rule RUF022 to enforce proper ordering of items listed in a module's __all__ attribute, and apply all the suggested fixes (currently around 88).

Example:

RUF022 [*] `__all__` is not sorted
  --> netbox/wireless/graphql/types.py:16:11
   |
14 |       from tenancy.graphql.types import TenantType
15 |
16 |   __all__ = (
   |  ___________^
17 | |     'WirelessLANType',
18 | |     'WirelessLANGroupType',
19 | |     'WirelessLinkType',
20 | | )
   | |_^
   |
help: Apply an isort-style sorting to `__all__`
14 |     from tenancy.graphql.types import TenantType
15 | 
16 | __all__ = (
17 +     'WirelessLANGroupType',
18 |     'WirelessLANType',
   -     'WirelessLANGroupType',
19 |     'WirelessLinkType',
20 | )

Justification

This will enforce predictable ordering of each module's declared contents.

*Originally created by @jeremystretch on 2/20/2026* ### Proposed Changes Enable Ruff rule [RUF022](https://docs.astral.sh/ruff/rules/unsorted-dunder-all/) to enforce proper ordering of items listed in a module's `__all__` attribute, and apply all the suggested fixes (currently around 88). Example: ``` RUF022 [*] `__all__` is not sorted --> netbox/wireless/graphql/types.py:16:11 | 14 | from tenancy.graphql.types import TenantType 15 | 16 | __all__ = ( | ___________^ 17 | | 'WirelessLANType', 18 | | 'WirelessLANGroupType', 19 | | 'WirelessLinkType', 20 | | ) | |_^ | help: Apply an isort-style sorting to `__all__` 14 | from tenancy.graphql.types import TenantType 15 | 16 | __all__ = ( 17 + 'WirelessLANGroupType', 18 | 'WirelessLANType', - 'WirelessLANGroupType', 19 | 'WirelessLinkType', 20 | ) ``` ### Justification This will enforce predictable ordering of each module's declared contents.

MrUnknownDE closed this issue

2026-04-05 16:25:03 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted type: housekeeping type: housekeeping type: housekeeping type: housekeeping type: housekeeping type: housekeeping type: housekeeping type: housekeeping type: housekeeping type: housekeeping type: housekeeping

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#299

Enable linting for __all__ ordering (RUF022) #299

Proposed Changes

Justification

Enable linting for `all` ordering (RUF022) #299