Fixes #21498: Fix Exception when changing a Cable Termination with an Interface Event Rule #27

New Issue

MrUnknownDE · 2026-04-05T16:21:15+02:00

MrUnknownDE commented

2026-04-05 16:21:15 +02:00

Originally created by @pheus on 4/1/2026

Fixes: #21498

This PR fixes a regression in deferred event serialization during cable edits.

When a cable termination is changed, CablePath rows can be deleted and recreated while endpoint instances are still in memory. If an event rule is active, the deferred serialization introduced in v4.5.2 can then hit a stale _path reference and raise CablePath.DoesNotExist.

The DCIM-side fix makes PathEndpoint.path recover from a stale _path reference with a narrow refresh of that field, and routes the remaining internal callers through path instead of accessing _path directly. This prevents the crash and keeps the fix scoped to the denormalized relation involved in path rebuilds.

This PR also includes the EventContext changes intentionally. While the PathEndpoint fix prevents the exception, it does not by itself address stale event payloads when the same object is enqueued multiple times within one request. EventContext now tracks the latest serialization source for coalesced duplicate enqueues, so deferred serialization uses the most recent queued instance while keeping the public object entry unchanged. Delete events are still serialized eagerly before the row becomes unavailable.

Finally, process_event_rules() now avoids mutating event_rule.action_data in place when merging event payload data.

Together, these changes fix the traceback from #21498, preserve the deferred-serialization optimization, and ensure event consumers receive the final queued state for coalesced updates.

*Originally created by @pheus on 4/1/2026* ### Fixes: #21498 This PR fixes a regression in deferred event serialization during cable edits. When a cable termination is changed, `CablePath` rows can be deleted and recreated while endpoint instances are still in memory. If an event rule is active, the deferred serialization introduced in v4.5.2 can then hit a stale `_path` reference and raise `CablePath.DoesNotExist`. The DCIM-side fix makes `PathEndpoint.path` recover from a stale `_path` reference with a narrow refresh of that field, and routes the remaining internal callers through `path` instead of accessing `_path` directly. This prevents the crash and keeps the fix scoped to the denormalized relation involved in path rebuilds. This PR also includes the `EventContext` changes intentionally. While the `PathEndpoint` fix prevents the exception, it does not by itself address stale event payloads when the same object is enqueued multiple times within one request. `EventContext` now tracks the latest serialization source for coalesced duplicate enqueues, so deferred serialization uses the most recent queued instance while keeping the public `object` entry unchanged. Delete events are still serialized eagerly before the row becomes unavailable. Finally, `process_event_rules()` now avoids mutating `event_rule.action_data` in place when merging event payload data. Together, these changes fix the traceback from #21498, preserve the deferred-serialization optimization, and ensure event consumers receive the final queued state for coalesced updates.

MrUnknownDE closed this issue

2026-04-05 16:21:15 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#27