Audit for missing pre-change snapshot calls #255

New Issue

MrUnknownDE · 2026-04-05T16:23:45+02:00

MrUnknownDE commented

2026-04-05 16:23:45 +02:00

Originally created by @arthanson on 3/2/2026

Proposed Changes

While working on #21277 noticed several other locations that were missing pre-change snapshots:

#	File	Line	Object Saved
1	netbox/virtualization/views.py	323	Device
2	netbox/dcim/views.py	2727	DeviceBay
3	netbox/dcim/views.py	4093	Device
4	netbox/dcim/views.py	4095	Device
5	netbox/dcim/forms/bulk_import.py	1384	Interface
6	netbox/ipam/forms/bulk_import.py	429	Device / VirtualMachine
7	netbox/ipam/forms/bulk_import.py	435	Device

These need to be audited and double check if there are any more missing.

Justification

Missing this call will prevent pre-change data from getting recorded in the changelog and can cause issues in migrations.

*Originally created by @arthanson on 3/2/2026* ### Proposed Changes While working on #21277 noticed several other locations that were missing pre-change snapshots: | # | File | Line | Object Saved | |---|----------------------------------|------|-------------------------| | 1 | netbox/virtualization/views.py | 323 | Device | | 2 | netbox/dcim/views.py | 2727 | DeviceBay | | 3 | netbox/dcim/views.py | 4093 | Device | | 4 | netbox/dcim/views.py | 4095 | Device | | 5 | netbox/dcim/forms/bulk_import.py | 1384 | Interface | | 6 | netbox/ipam/forms/bulk_import.py | 429 | Device / VirtualMachine | | 7 | netbox/ipam/forms/bulk_import.py | 435 | Device | These need to be audited and double check if there are any more missing. ### Justification Missing this call will prevent pre-change data from getting recorded in the changelog and can cause issues in migrations.

MrUnknownDE closed this issue

2026-04-05 16:23:45 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox severity: medium severity: medium severity: medium severity: medium severity: medium severity: medium status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted status: accepted type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug type: bug

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#255