#21330 optimize the assignment of tags when saving an object #214

New Issue

MrUnknownDE · 2026-04-05T16:23:02+02:00

MrUnknownDE commented

2026-04-05 16:23:02 +02:00

Originally created by @arthanson on 3/5/2026

Fixes: #21330

Taggit was causing N+1 queries here. Created a new NetBoxTaggableManager replacing the add function on taggit and generally follows what it does but does a single bulk-insert of all tags instead of one at a time. Also a small optimization on the serializer. Could probably be upstreamed into Taggit, will look at opening an optimization PR there.

Created a new site with 12 tag assignments - checking the POST Request:

main branch: 76 SQL queries
this branch: 29 SQL queries

Note: After adding site, with debug toolbar, go to the history menu, find the post request and choose 'switch' to that then look at SQL queries.

*Originally created by @arthanson on 3/5/2026* ### Fixes: #21330 Taggit was causing N+1 queries here. Created a new NetBoxTaggableManager replacing the add function on taggit and generally follows what it does but does a single bulk-insert of all tags instead of one at a time. Also a small optimization on the serializer. Could probably be upstreamed into Taggit, will look at opening an optimization PR there. Created a new site with 12 tag assignments - checking the POST Request: main branch: 76 SQL queries this branch: 29 SQL queries **Note:** After adding site, with debug toolbar, go to the history menu, find the post request and choose 'switch' to that then look at SQL queries.

MrUnknownDE closed this issue

2026-04-05 16:23:02 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#214