Fixes #21618: Preserve cable terminations when bulk-editing cable profile #186

New Issue

MrUnknownDE · 2026-04-05T16:22:46+02:00

MrUnknownDE commented

2026-04-05 16:22:46 +02:00

Originally created by @GeertJohan on 3/9/2026

Fixes: #21618

Summary

Cache termination objects in update_terminations() before deleting CableTermination records when force=True
Without this fix, the a_terminations/b_terminations properties query the DB after deletion and return empty lists, causing all terminations to be silently lost
Removes a leftover debug print() statement from PR #21069

Root Cause

PR #21069 added update_terminations(force=True) to handle profile changes. This method first deletes all existing CableTermination records, then reads self.a_terminations/self.b_terminations to recreate them. When the single-object edit form is used, these properties are populated from form data (_a_terminations/_b_terminations private attrs). But during bulk edit (or any save() without explicitly setting terminations), the properties fall back to self.terminations.all() — which returns empty results because the records were just deleted.

The fix caches the termination objects from get_terminations() into _a_terminations/_b_terminations before the delete step, so they're available for recreation.

Test plan

Added test_cable_profile_change_preserves_terminations to CableTestCase
Verified test fails without the fix (AssertionError: 0 != 2)
Verified test passes with the fix
All existing CableTestCase tests pass
Cable path tests (test_cablepaths2) unaffected

🤖 Generated with Claude Code

*Originally created by @GeertJohan on 3/9/2026* ### Fixes: #21618 ## Summary - Cache termination objects in `update_terminations()` before deleting `CableTermination` records when `force=True` - Without this fix, the `a_terminations`/`b_terminations` properties query the DB after deletion and return empty lists, causing all terminations to be silently lost - Removes a leftover debug `print()` statement from PR #21069 ## Root Cause PR #21069 added `update_terminations(force=True)` to handle profile changes. This method first deletes all existing `CableTermination` records, then reads `self.a_terminations`/`self.b_terminations` to recreate them. When the single-object edit form is used, these properties are populated from form data (`_a_terminations`/`_b_terminations` private attrs). But during bulk edit (or any `save()` without explicitly setting terminations), the properties fall back to `self.terminations.all()` — which returns empty results because the records were just deleted. The fix caches the termination objects from `get_terminations()` into `_a_terminations`/`_b_terminations` before the delete step, so they're available for recreation. ## Test plan - [x] Added `test_cable_profile_change_preserves_terminations` to `CableTestCase` - [x] Verified test **fails** without the fix (`AssertionError: 0 != 2`) - [x] Verified test **passes** with the fix - [x] All existing `CableTestCase` tests pass - [x] Cable path tests (`test_cablepaths2`) unaffected 🤖 Generated with [Claude Code](https://claude.com/claude-code)

MrUnknownDE closed this issue

2026-04-05 16:22:46 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#186