20048 cleanup get_viewname URL resolution #1492

New Issue

MrUnknownDE · 2026-04-06T02:29:47+02:00

MrUnknownDE commented

2026-04-06 02:29:47 +02:00

Originally created by @arthanson on 8/7/2025

Fixes: #20048

adds a get_action_url to replace the get_viewname / reverse sequence in the app, and allows it to be replaceable by models that need a different URL pattern then the standard.

get_viewname is used in two filters viewname and validated_viewname which gets the viewname and then passes this to the url template tag so added in an action_url template tag (in netbox/utilities/templatetags/helpers.py) to use the get_action_url and have cleaner syntax goes from {% url object|viewname:'list' %} to {% action_url object 'list' %}. As a template tag it also supports as syntax so allows the following replacement:

{% with viewname=qs.model|validated_viewname:"list" %}
<a href="{% url viewname %}

with cleaner:

{% action_url qs.model 'list' as list_url %}
<a href="{{ list_url }}

netbox/extras/dashboard/widgets.py needed the returned context changed as viewname isn't returned anymore but the template just uses it in an error message, so just updated the error message.

NetBoxFeatureSet still uses get_viewname in the get_absolute_url function, but that is fine as any model that is overriding _get_action_url would also override get_absoulte_url as well so it doesn't need to be changed there.

NetBoxAPIHyperlinkedIdentityField and NetBoxURLHyperlinkedIdentityField also use get_viewname and there isn't a good way around that, but if needed any plugin should be able to override those as needed.

*Originally created by @arthanson on 8/7/2025* ### Fixes: #20048 adds a `get_action_url` to replace the `get_viewname` / reverse sequence in the app, and allows it to be replaceable by models that need a different URL pattern then the standard. `get_viewname` is used in two filters `viewname` and `validated_viewname` which gets the viewname and then passes this to the url template tag so added in an `action_url` template tag (in netbox/utilities/templatetags/helpers.py) to use the get_action_url and have cleaner syntax goes from `{% url object|viewname:'list' %}` to `{% action_url object 'list' %}`. As a template tag it also supports `as` syntax so allows the following replacement: ``` {% with viewname=qs.model|validated_viewname:"list" %} <a href="{% url viewname %} ``` with cleaner: ``` {% action_url qs.model 'list' as list_url %} <a href="{{ list_url }} ``` `netbox/extras/dashboard/widgets.py` needed the returned context changed as viewname isn't returned anymore but the template just uses it in an error message, so just updated the error message. NetBoxFeatureSet still uses get_viewname in the get_absolute_url function, but that is fine as any model that is overriding _get_action_url would also override get_absoulte_url as well so it doesn't need to be changed there. NetBoxAPIHyperlinkedIdentityField and NetBoxURLHyperlinkedIdentityField also use get_viewname and there isn't a good way around that, but if needed any plugin should be able to override those as needed.

MrUnknownDE closed this issue

2026-04-06 02:29:47 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1492