Reduce per-position ORM lookups when tracing profiled cable paths #135

New Issue

MrUnknownDE · 2026-04-05T16:22:05+02:00

MrUnknownDE commented

2026-04-05 16:22:05 +02:00

Originally created by @pheus on 3/17/2026

NetBox Version

v4.5.4

Python Version

3.12

Area(s) of Concern

User Interface
REST API
GraphQL API
Python ORM
Other

Details

While reviewing the multi-position tracing fix in #21681, I noticed a follow-up performance opportunity in CablePath.from_origin() when tracing profiled cables.

Today, Step 6 resolves each (termination, position) pair by calling cable_profile.get_peer_termination() individually. That is correct, but it can result in one ORM lookup per pair, which becomes increasingly expensive for multi-position and multi-connector profiles.

A follow-up optimization could batch the peer lookup for a profiled segment and resolve the mapped positions in memory, rather than querying once per pair. This should reduce query count without changing behavior.

I do not have a formal benchmark yet; this came up during code review rather than production troubleshooting. The expected result would be fewer database queries and better cable-path tracing performance, especially for larger profiled/trunk topologies.

*Originally created by @pheus on 3/17/2026* ### NetBox Version v4.5.4 ### Python Version 3.12 ### Area(s) of Concern - [ ] User Interface - [ ] REST API - [ ] GraphQL API - [x] Python ORM - [ ] Other ### Details While reviewing the multi-position tracing fix in #21681, I noticed a follow-up performance opportunity in `CablePath.from_origin()` when tracing profiled cables. Today, Step 6 resolves each `(termination, position)` pair by calling `cable_profile.get_peer_termination()` individually. That is correct, but it can result in one ORM lookup per pair, which becomes increasingly expensive for multi-position and multi-connector profiles. A follow-up optimization could batch the peer lookup for a profiled segment and resolve the mapped positions in memory, rather than querying once per pair. This should reduce query count without changing behavior. I do not have a formal benchmark yet; this came up during code review rather than production troubleshooting. The expected result would be fewer database queries and better cable-path tracing performance, especially for larger profiled/trunk topologies.

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label complexity: medium complexity: medium complexity: medium complexity: medium complexity: medium complexity: medium complexity: medium netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox netbox status: backlog status: backlog status: backlog status: backlog type: performance type: performance

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#135