Closes #20241: Record A & B terminations on cable changelog records #1339

New Issue

MrUnknownDE · 2026-04-05T23:33:09+02:00

MrUnknownDE commented

2026-04-05 23:33:09 +02:00

Originally created by @jeremystretch on 9/4/2025

Closes: #20241

Call save() twice for new cables (before and after updating the terminations)
Consolidate the logic for getting/setting A/B terminations into the new _get_x_terminations() and _set_x_terminations() methods
Add get_terminations() to Cable to return a mapping of all current CableTerminations
Move the logic for updating CableTerminations to a new update_terminations() method on Cable
Override serialize_object() on Cable to add a_terminations and b_terminations to the change data
Add a complementary deserialize_object() method (for completeness)
Update some testing utilities to specifically check for creation records (ignoring subsequent update records)

*Originally created by @jeremystretch on 9/4/2025* ### Closes: #20241 - Call `save()` twice for new cables (before and after updating the terminations) - Consolidate the logic for getting/setting A/B terminations into the new `_get_x_terminations()` and `_set_x_terminations()` methods - Add `get_terminations()` to Cable to return a mapping of all current CableTerminations - Move the logic for updating CableTerminations to a new `update_terminations()` method on Cable - Override `serialize_object()` on Cable to add `a_terminations` and `b_terminations` to the change data - Add a complementary `deserialize_object()` method (for completeness) - Update some testing utilities to specifically check for creation records (ignoring subsequent update records)

MrUnknownDE closed this issue

2026-04-05 23:33:09 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1339