Fixes #20234: Correct add_button return_url for prerequisite models #1321

New Issue

MrUnknownDE · 2026-04-05T23:23:30+02:00

MrUnknownDE commented

2026-04-05 23:23:30 +02:00

Originally created by @pheus on 9/5/2025

Fixes: #20234

Summary
The generic prerequisite include was passing request.path as the second positional argument to the add_button template tag. Because the tag expects (model, action, return_url), this caused request.path to be interpreted as action, breaking the "+ Add" link in banners such as "Before you can add a power feed you must first create a power panel."

Change
Pass the return_url by name so it’s bound correctly by the tag:

{% add_button prerequisite_model return_url=request.path %}

User impact
Clicking "+ Add" on any prerequisite banner now opens the correct add form and returns the user to the originating page upon completion.

*Originally created by @pheus on 9/5/2025* ### Fixes: #20234 **Summary** The generic prerequisite include was passing `request.path` as the second positional argument to the `add_button` template tag. Because the tag expects `(model, action, return_url)`, this caused `request.path` to be interpreted as `action`, breaking the "+ Add" link in banners such as "Before you can add a power feed you must first create a power panel." **Change** Pass the `return_url` by name so it’s bound correctly by the tag: ~~~django {% add_button prerequisite_model return_url=request.path %} ~~~ **User impact** Clicking "+ Add" on any prerequisite banner now opens the correct add form and returns the user to the originating page upon completion.

MrUnknownDE closed this issue

2026-04-05 23:23:30 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1321