#14329 Improve diffs for custom_fields #132

New Issue

MrUnknownDE · 2026-04-05T16:22:05+02:00

MrUnknownDE commented

2026-04-05 16:22:05 +02:00

Originally created by @arthanson on 3/17/2026

Fixes: #14329

Needed to add a deep_compare_dict to process the diffs instead of the current shallow_compare_dict, as custom_fields is a nested dict inside the diff. Two places for change - one modifying the "Difference" panel and the other for the "Pre-Change Data" and "Post-Change Data"

I created 6 custom fields on a Tenant and modified one of them. On the original note all the custom fields are highlighted, even though only modified one of them:

Monosnap Tenancy | tenant Cyberdyne Systems updated by ahanson | NetBox 2026-03-17 09-04-29

On this version, only the custom field that actually got modified is highlighted:

Monosnap Tenancy | tenant Cyberdyne Systems updated by ahanson | NetBox 2026-03-17 09-01-09

*Originally created by @arthanson on 3/17/2026* ### Fixes: #14329 Needed to add a deep_compare_dict to process the diffs instead of the current shallow_compare_dict, as custom_fields is a nested dict inside the diff. Two places for change - one modifying the "Difference" panel and the other for the "Pre-Change Data" and "Post-Change Data" I created 6 custom fields on a Tenant and modified one of them. On the original note all the custom fields are highlighted, even though only modified one of them: <img width="1112" height="1101" alt="Monosnap Tenancy | tenant Cyberdyne Systems updated by ahanson | NetBox 2026-03-17 09-04-29" src="https://github.com/user-attachments/assets/cc4dc6e9-bff0-4376-b409-db0302b55511" /> On this version, only the custom field that actually got modified is highlighted: <img width="1109" height="911" alt="Monosnap Tenancy | tenant Cyberdyne Systems updated by ahanson | NetBox 2026-03-17 09-01-09" src="https://github.com/user-attachments/assets/f17cd460-61d3-43f2-a7aa-be58e6f6e59c" />

MrUnknownDE closed this issue

2026-04-05 16:22:05 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#132