Closes #19523: Add instance count filter to Module and Device Types #1299

New Issue

MrUnknownDE · 2026-04-05T23:12:07+02:00

MrUnknownDE commented

2026-04-05 23:12:07 +02:00

Originally created by @pheus on 9/7/2025

Fixes: #19523

Summary

Add filters to quickly find used/unused types and query by count:

has_instances (bool) — UI, REST, GraphQL
instance_count (int with =, gt, gte, lt, lte, range) — REST, GraphQL

Implementation

DeviceTypeFilterSet & ModuleTypeFilterSet: add has_instances and instance_count using count_related(); a single method handles integer lookups.
GraphQL: Strawberry filters via @filter_field; annotate instance_count and delegate lookups with process_filters(prefix="…instance_count__").
REST examples:
- /api/dcim/device-types/?has_instances=true
- /api/dcim/device-types/?instance_count__gte=10
- /api/dcim/module-types/?has_instances=false
Tests: filterset tests for boolean & numeric cases.

*Originally created by @pheus on 9/7/2025*  ### Fixes: #19523 **Summary** Add filters to quickly find used/unused types and query by count: - `has_instances` (bool) — **UI**, **REST**, **GraphQL** - `instance_count` (int with `=, gt, gte, lt, lte, range`) — **REST**, **GraphQL** **Implementation** - `DeviceTypeFilterSet` & `ModuleTypeFilterSet`: add `has_instances` and `instance_count` using `count_related()`; a single method handles integer lookups. - GraphQL: Strawberry filters via `@filter_field`; annotate `instance_count` and delegate lookups with `process_filters(prefix="…instance_count__")`. - REST examples: - `/api/dcim/device-types/?has_instances=true` - `/api/dcim/device-types/?instance_count__gte=10` - `/api/dcim/module-types/?has_instances=false` - Tests: filterset tests for boolean & numeric cases.

MrUnknownDE closed this issue

2026-04-05 23:12:07 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1299