RFC: Fixes #20290: Prevent ObjectType queries when table doesn't exist #1155

New Issue

MrUnknownDE · 2026-04-05T21:14:19+02:00

MrUnknownDE commented

2026-04-05 21:14:19 +02:00

Originally created by @jnovinger on 10/2/2025

Fixes: #20290

In v4.4.0, ObjectType became a concrete model with a database table. Signal handlers query this table during migrations, but the table doesn't exist yet during 3.7.x→4.4.0 upgrades. The query failures poison the transaction and abort migrations.

This commits adds a objecttype_table_exists() helper and and uses it in three places:

has_feature() in netbox/models/features.py
update_object_types() in core/signals.py
Search backend cache() in search/backends.py

If core_objecttype table doesn't exist, operations return early instead of querying. Once table exists, normal operation resumes.

Pros

no migration changes
one helper function, three identical checks
easy to test, verify, and remove later if needed
queries PostgreSQL system catalogs for table existence - won't poison transactions

Cons

fixes symptoms, not root cause
touches 3 different files instead of one surgical fix
future code querying ObjectType during migrations could still fail/future developers might not know to add this check in new code
adds table introspection overhead (could cache if needed) to every has_feature() call
could introspect table name from model instead of hard-coding

*Originally created by @jnovinger on 10/2/2025* ### Fixes: #20290 In v4.4.0, `ObjectType` became a concrete model with a database table. Signal handlers query this table during migrations, but the table doesn't exist yet during 3.7.x→4.4.0 upgrades. The query failures poison the transaction and abort migrations. This commits adds a `objecttype_table_exists()` helper and and uses it in three places: - `has_feature()` in netbox/models/features.py - `update_object_types()` in core/signals.py - `Search backend cache()` in search/backends.py If `core_objecttype` table doesn't exist, operations return early instead of querying. Once table exists, normal operation resumes. Pros - no migration changes - one helper function, three identical checks - easy to test, verify, and remove later if needed - queries PostgreSQL system catalogs for table existence - won't poison transactions Cons - fixes symptoms, not root cause - touches 3 different files instead of one surgical fix - future code querying `ObjectType` during migrations could still fail/future developers might not know to add this check in new code - adds table introspection overhead (could cache if needed) to every `has_feature()` call - could introspect table name from model instead of hard-coding

MrUnknownDE closed this issue

2026-04-05 21:14:19 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1155