Fixes #20471: Update NumericRange handling to use half-open intervals #1150

New Issue

MrUnknownDE · 2026-04-05T21:09:41+02:00

MrUnknownDE commented

2026-04-05 21:09:41 +02:00

Originally created by @pheus on 10/2/2025

Fixes: #20471

Summary

Normalize integer range handling to use half‑open intervals [lower, upper) across the app. Inclusive inputs are still accepted (forms/CSV/API) but are converted to a canonical half‑open form on save and serialization. This yields stable pre/post snapshots and prevents spurious change log entries when saving an unchanged VLANGroup.

Changes

Canonicalize all NumericRange values for VLANGroup.vid_ranges to [lo, hi) in forms, serializers, and utilities.
Ensure change‑logging compares normalized values to avoid no‑op diffs.
Update tests for round‑trip stability and “no new changelog on no‑op save.”

Notes

No database schema changes.
Backward‑compatible: existing data remains valid; user‑facing behavior is unchanged.

*Originally created by @pheus on 10/2/2025*  ### Fixes: #20471  **Summary** Normalize integer range handling to use half‑open intervals `[lower, upper)` across the app. Inclusive inputs are still accepted (forms/CSV/API) but are converted to a canonical half‑open form on save and serialization. This yields stable pre/post snapshots and prevents spurious change log entries when saving an unchanged `VLANGroup`. **Changes** - Canonicalize all `NumericRange` values for `VLANGroup.vid_ranges` to `[lo, hi)` in forms, serializers, and utilities. - Ensure change‑logging compares normalized values to avoid no‑op diffs. - Update tests for round‑trip stability and “no new changelog on no‑op save.” **Notes** - No database schema changes. - Backward‑compatible: existing data remains valid; user‑facing behavior is unchanged.

MrUnknownDE closed this issue

2026-04-05 21:09:41 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1150