Fixes #20497: Add range_contains lookup and fix VLANGroup VID range filtering #1118

New Issue

MrUnknownDE · 2026-04-05T20:49:52+02:00

MrUnknownDE commented

2026-04-05 20:49:52 +02:00

Originally created by @pheus on 10/6/2025

Fixes: #20497

Summary
Introduce a generic ORM lookup range_contains for ArrayField(RangeField) to correctly match rows where a scalar value is contained by any range in the array (e.g., VLANGroup.vid_ranges). This replaces the raw‑SQL helper used by the VLAN group filter and aligns REST and GraphQL semantics with PostgreSQL range operators.

Changes

extras: Add and register the range_contains lookup (guarded to ArrayField(RangeField)).
ipam/filtersets: Refactor VLANGroup FilterSet (contains_vid) to use the lookup (remove raw SQL).
GraphQL schema:
- Add an IntegerRangeArrayLookup input and wire VLANGroup.vid_ranges to it.
- Keep the public API friendly: clients use vid_ranges: { contains: <Int> }, which maps internally to __range_contains.

Tests

Add ORM unit tests for the lookup (positive, negative, and boundary cases).
Add REST FilterSet tests for ?contains_vid=<int> (hit/miss and exclusive upper bound).

*Originally created by @pheus on 10/6/2025* ### Fixes: #20497 **Summary** Introduce a generic ORM lookup `range_contains` for `ArrayField(RangeField)` to correctly match rows where a scalar value is contained by **any** range in the array (e.g., `VLANGroup.vid_ranges`). This replaces the raw‑SQL helper used by the VLAN group filter and aligns REST and GraphQL semantics with PostgreSQL range operators. **Changes** - **extras**: Add and register the `range_contains` lookup (guarded to `ArrayField(RangeField)`). - **ipam/filtersets**: Refactor `VLANGroup` FilterSet (`contains_vid`) to use the lookup (remove raw SQL). - **GraphQL schema**: - Add an `IntegerRangeArrayLookup` input and wire `VLANGroup.vid_ranges` to it. - Keep the public API friendly: clients use `vid_ranges: { contains: <Int> }`, which maps internally to `__range_contains`. **Tests** - Add ORM unit tests for the lookup (positive, negative, and boundary cases). - Add REST FilterSet tests for `?contains_vid=<int>` (hit/miss and exclusive upper bound).

MrUnknownDE closed this issue

2026-04-05 20:49:52 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1118

Fixes #20497: Add range_contains lookup and fix VLANGroup VID range filtering #1118

Fixes: #20497

Fixes #20497: Add `range_contains` lookup and fix VLANGroup VID range filtering #1118