Closes #20527: Address deprecation warnings #1101

New Issue

MrUnknownDE · 2026-04-05T20:39:47+02:00

MrUnknownDE commented

2026-04-05 20:39:47 +02:00

Originally created by @pheus on 10/8/2025

Fixes: #20527

This PR removes the warnings reported in #20527 by updating form fields, GraphQL resolvers, table accessors, and PostgreSQL aggregates to their current, forward‑compatible APIs. It also consolidates a GraphQL import path for clarity.

None of the changes alter user‑visible behavior; they silence deprecations and improve typing so we’re ready for Django 6.0, Strawberry ≥1.0, and django‑tables2 v3.

What’s changed

Forms (URLField default scheme)

Contact import & model forms: Opt into the HTTPS default by adding assume_scheme='https' to:
- ContactImportForm.link
- ContactForm.link
Rationale: Django 6.0 changes the default URL scheme to HTTPS. Passing assume_scheme='https' silences RemovedInDjango60Warning during form construction.

Optional backstop (not included in this PR): set FORMS_URLFIELD_ASSUME_HTTPS = True in settings to adopt the future default globally during the Django 5.x window.

GraphQL (Strawberry)

Annotate reserved args: Replace untyped info parameters with info: Info across GraphQL mixins and types to remove the

“argument name‑based matching of info is deprecated”
warning and align with Strawberry’s typing rules.
Directive typing: Where a filter method uses a prefix directive, annotate as prefix: DirectiveValue[str] for correctness.
Import path tidy‑up: Consolidate the import for ObjectChangeType under core.graphql.types to keep type hints consistent.

Tables (django-tables2)

Accessor separator: Update DeviceTable to use device_type__u_height instead of device_type.u_height to comply with django_tables2’s __ accessor convention and remove the deprecation.

Querysets (PostgreSQL aggregates)

Kwarg rename: Replace deprecated ordering= with order_by= on EmptyGroupByJSONBAgg(...) to match Django 5.2+.

*Originally created by @pheus on 10/8/2025*  ### Fixes: #20527 This PR removes the warnings reported in #20527 by updating form fields, GraphQL resolvers, table accessors, and PostgreSQL aggregates to their current, forward‑compatible APIs. It also consolidates a GraphQL import path for clarity. None of the changes alter user‑visible behavior; they silence deprecations and improve typing so we’re ready for Django 6.0, Strawberry ≥1.0, and django‑tables2 v3. --- ### What’s changed #### Forms (URLField default scheme) - **Contact import & model forms:** Opt into the HTTPS default by adding `assume_scheme='https'` to: - `ContactImportForm.link` - `ContactForm.link` - Rationale: Django 6.0 changes the default URL scheme to HTTPS. Passing `assume_scheme='https'` silences `RemovedInDjango60Warning` during form construction. > _Optional backstop (not included in this PR):_ set `FORMS_URLFIELD_ASSUME_HTTPS = True` in settings to adopt the future default globally during the Django 5.x window. #### GraphQL (Strawberry) - **Annotate reserved args:** Replace untyped `info` parameters with `info: Info` across GraphQL mixins and types to remove the > “argument name‑based matching of `info` is deprecated” warning and align with Strawberry’s typing rules. - **Directive typing:** Where a filter method uses a `prefix` directive, annotate as `prefix: DirectiveValue[str]` for correctness. - **Import path tidy‑up:** Consolidate the import for `ObjectChangeType` under `core.graphql.types` to keep type hints consistent. #### Tables (django-tables2) - **Accessor separator:** Update `DeviceTable` to use `device_type__u_height` instead of `device_type.u_height` to comply with `django_tables2`’s `__` accessor convention and remove the deprecation. #### Querysets (PostgreSQL aggregates) - **Kwarg rename:** Replace deprecated `ordering=` with `order_by=` on `EmptyGroupByJSONBAgg(...)` to match Django 5.2+.

MrUnknownDE closed this issue

2026-04-05 20:39:47 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1101