Fixes #20466: Correct handling of assigned filter logic #1099

New Issue

MrUnknownDE · 2026-04-05T20:39:47+02:00

MrUnknownDE commented

2026-04-05 20:39:47 +02:00

Originally created by @pheus on 10/8/2025

Fixes: #20466

Summary

Correct the custom GraphQL filter IPAddressFilter.assigned to use the nested relation prefix supplied by Strawberry‑Django.
Prior behavior built a non‑prefixed Q, so when used under another filter (e.g., Device → primary_ip4), Django attempted to resolve assigned_object_id on the outer model and failed.
New behavior dynamically qualifies the lookup with prefix, ensuring the condition targets the nested IPAddress.

Change

@strawberry_django.filter_field()
def assigned(self, value: bool, prefix) -> Q:
-    return Q(assigned_object_id__isnull=(not value))
+    return Q(**{f"{prefix}assigned_object_id__isnull": not value})

Why

Nested GraphQL queries like the example below errored due to the missing prefix; with this change they work as intended.

query {
  device_list(filters: { primary_ip4: { assigned: true } }) {
    id
    name
    primary_ip4 { address }
  }
}

Follow‑up

Propose a small audit for other @strawberry_django.filter_field methods that construct raw Q(...) lookups without applying prefix.

*Originally created by @pheus on 10/8/2025* ### Fixes: #20466  #### Summary - Correct the custom GraphQL filter `IPAddressFilter.assigned` to use the nested relation `prefix` supplied by Strawberry‑Django. - Prior behavior built a non‑prefixed `Q`, so when used under another filter (e.g., `Device → primary_ip4`), Django attempted to resolve `assigned_object_id` on the outer model and failed. - New behavior dynamically qualifies the lookup with `prefix`, ensuring the condition targets the nested `IPAddress`. #### Change ```diff @strawberry_django.filter_field() def assigned(self, value: bool, prefix) -> Q: - return Q(assigned_object_id__isnull=(not value)) + return Q(**{f"{prefix}assigned_object_id__isnull": not value}) ``` #### Why Nested GraphQL queries like the example below errored due to the missing prefix; with this change they work as intended. ```graphql query { device_list(filters: { primary_ip4: { assigned: true } }) { id name primary_ip4 { address } } } ``` #### Follow‑up - Propose a small audit for other `@strawberry_django.filter_field` methods that construct raw `Q(...)` lookups without applying `prefix`.

MrUnknownDE closed this issue

2026-04-05 20:39:47 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1099

Fixes #20466: Correct handling of assigned filter logic #1099

Fixes: #20466

Summary

Change

Why

Follow‑up

Fixes #20466: Correct handling of `assigned` filter logic #1099