Closes #20516: Add ranges_to_string_list and render VLAN Group VID ranges with ArrayColumn #1094

New Issue

MrUnknownDE · 2026-04-05T20:34:47+02:00

MrUnknownDE commented

2026-04-05 20:34:47 +02:00

Originally created by @pheus on 10/9/2025

Fixes: #20516

Summary

Add ranges_to_string_list(ranges) -> list[str], which formats numeric ranges as human‑readable strings (e.g., ["1-5", "8", "10-12"]).
Refactor ranges_to_string(ranges) to delegate to the new helper:
```
if not ranges:
    return ''
return ','.join(ranges_to_string_list(ranges))
```
This preserves the existing output (comma‑separated with no spaces) while enabling callers to control separators when needed.
Improve VLAN Group rendering by switching the table column to use a list accessor with ArrayColumn, yielding ", " spacing in the UI without changing underlying data or the string helper’s behavior.

Implementation notes

ranges_to_string remains fully backward‑compatible in both signature and output.
VLAN Group table uses a list accessor (e.g., vid_ranges_items) with ArrayColumn, while keeping the existing vid_ranges_list string property available to avoid breaking saved table configs.

Testing

Add unit tests covering:
- Singleton ranges ("8") vs. hyphen ranges ("1-5")
- ranges_to_string_list()

Backwards compatibility

No breaking changes. Existing uses of ranges_to_string() and VLANGroup.vid_ranges_list continue to work as before.

*Originally created by @pheus on 10/9/2025*  ### Fixes: #20516  **Summary** - Add `ranges_to_string_list(ranges) -> list[str]`, which formats numeric ranges as human‑readable strings (e.g., `["1-5", "8", "10-12"]`). - Refactor `ranges_to_string(ranges)` to delegate to the new helper: ```py if not ranges: return '' return ','.join(ranges_to_string_list(ranges)) ``` This preserves the existing output (comma‑separated with **no spaces**) while enabling callers to control separators when needed. - Improve VLAN Group rendering by switching the table column to use a list accessor with `ArrayColumn`, yielding `", "` spacing in the UI without changing underlying data or the string helper’s behavior. **Implementation notes** - `ranges_to_string` remains fully backward‑compatible in both signature and output. - VLAN Group table uses a list accessor (e.g., `vid_ranges_items`) with `ArrayColumn`, while keeping the existing `vid_ranges_list` string property available to avoid breaking saved table configs. **Testing** - Add unit tests covering: - Singleton ranges (`"8"`) vs. hyphen ranges (`"1-5"`) - `ranges_to_string_list()` **Backwards compatibility** - No breaking changes. Existing uses of `ranges_to_string()` and `VLANGroup.vid_ranges_list` continue to work as before.

MrUnknownDE closed this issue

2026-04-05 20:34:47 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1094

Closes #20516: Add ranges_to_string_list and render VLAN Group VID ranges with ArrayColumn #1094

Fixes: #20516

Closes #20516: Add `ranges_to_string_list` and render VLAN Group VID ranges with `ArrayColumn` #1094