Fixes #20542: Add form prefix to POST handler in ObjectEditView #1092

New Issue

MrUnknownDE · 2026-04-05T20:34:47+02:00

MrUnknownDE commented

2026-04-05 20:34:47 +02:00

Originally created by @jnovinger on 10/9/2025

Fixes: #20542

Commit d22246688 added form prefix support to the GET handler to fix Markdown preview functionality in quick add modals. The form prefix allows Django to properly namespace field names and IDs when rendering forms within the quick add modal context.

However, the corresponding change was not made to the POST handler. This created a mismatch where form fields were rendered with the quickadd- prefix during GET requests, but the POST handler instantiated forms without the prefix. When users submitted quick add forms, Django looked for unprefixed field names like address and status in the POST data, but the actual submitted data used prefixed names like quickadd-address and quickadd-status. This caused validation to fail immediately with "This field is required" errors for all required fields, making every quick add form unusable.

The fix adds the same prefix detection logic to the POST handler that was added to the GET handler, checking for the _quickadd parameter in the query string and applying the quickadd prefix when present. This ensures consistent form field naming between rendering and validation.

A regression test has been added to MACAddressTestCase to verify that MAC addresses can be successfully created via the quick add modal, preventing this issue from recurring. This test should be promoted to a template test whenever it becomes possible to determine if a model should support quick-add functionality.

*Originally created by @jnovinger on 10/9/2025* Fixes: #20542 Commit d22246688 added form prefix support to the `GET` handler to fix Markdown preview functionality in quick add modals. The form prefix allows Django to properly namespace field names and IDs when rendering forms within the quick add modal context. However, the corresponding change was not made to the `POST` handler. This created a mismatch where form fields were rendered with the `quickadd-` prefix during `GET` requests, but the `POST` handler instantiated forms without the prefix. When users submitted quick add forms, Django looked for unprefixed field names like `address` and `status` in the `POST` data, but the actual submitted data used prefixed names like `quickadd-address` and `quickadd-status`. This caused validation to fail immediately with "This field is required" errors for all required fields, making every quick add form unusable. The fix adds the same prefix detection logic to the `POST` handler that was added to the `GET` handler, checking for the `_quickadd` parameter in the query string and applying the `quickadd` prefix when present. This ensures consistent form field naming between rendering and validation. A regression test has been added to `MACAddressTestCase` to verify that MAC addresses can be successfully created via the quick add modal, preventing this issue from recurring. This test should be promoted to a template test whenever it becomes possible to determine if a model should support quick-add functionality.

MrUnknownDE closed this issue

2026-04-05 20:34:47 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1092

Fixes #20542: Add form prefix to POST handler in ObjectEditView #1092

Fixes #20542: Add form prefix to `POST` handler in `ObjectEditView` #1092