Fixes #20554: Add ContentTypeFilter to several filtersets #1056

New Issue

MrUnknownDE · 2026-04-05T20:06:57+02:00

MrUnknownDE commented

2026-04-05 20:06:57 +02:00

Originally created by @pheus on 10/15/2025

Fixes: #20554

Summary
Switch ipam.Service filtering to use ContentTypeFilter for parent_object_type and apply the same approach anywhere we expose a generic relation via filters (e.g., object_type, related_object_type, assigned_object_type). This lets GET filters accept the documented <app>.<model> form (e.g., virtualization.virtualmachine) and aligns GET with POST and existing usability across the app.

What changed

Replaced integer-based validation with ContentTypeFilter for parent_object_type in the Services filterset.
Standardized on ContentTypeFilter for similar parameters across filtersets where applicable.
Added/updated tests to cover filtering via <app>.<model> for the affected params.

Why
Fixes the “Value must be an integer” error when filtering Services by parent_object_type and brings behavior in line with how generic relations are documented and used elsewhere. No database or schema changes.

*Originally created by @pheus on 10/15/2025* ### Fixes: #20554 **Summary** Switch `ipam.Service` filtering to use `ContentTypeFilter` for `parent_object_type` and apply the same approach anywhere we expose a generic relation via filters (e.g., `object_type`, `related_object_type`, `assigned_object_type`). This lets GET filters accept the documented `<app>.<model>` form (e.g., `virtualization.virtualmachine`) and aligns GET with POST and existing usability across the app. **What changed** - Replaced integer-based validation with `ContentTypeFilter` for `parent_object_type` in the Services filterset. - Standardized on `ContentTypeFilter` for similar parameters across filtersets where applicable. - Added/updated tests to cover filtering via `<app>.<model>` for the affected params. **Why** Fixes the “Value must be an integer” error when filtering Services by `parent_object_type` and brings behavior in line with how generic relations are documented and used elsewhere. No database or schema changes.

MrUnknownDE closed this issue

2026-04-05 20:06:57 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1056