Fixes #20610: Correct VLAN ID range calculation logic #1040

Closed
opened 2026-04-05 19:57:50 +02:00 by MrUnknownDE · 0 comments
Owner

Originally created by @pheus on 10/17/2025

Fixes: #20610

Correct an off‑by‑one in VLANGroup._total_vlan_ids by computing lengths with half‑open [lo, hi) semantics during save(). Removes the +1, adds a test and includes a data migration to backfill existing _total_vlan_ids.

No schema changes.

*Originally created by @pheus on 10/17/2025* <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #20610 <!-- Please include a summary of the proposed changes below. --> Correct an off‑by‑one in `VLANGroup._total_vlan_ids` by computing lengths with half‑open `[lo, hi)` semantics during `save()`. Removes the `+1`, adds a test and includes a data migration to backfill existing `_total_vlan_ids`. No schema changes.
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/netbox#1040