Closes #20399: Add assigned and primary filters for MACAddress #1031

New Issue

MrUnknownDE · 2026-04-05T19:56:27+02:00

MrUnknownDE commented

2026-04-05 19:56:27 +02:00

Originally created by @pheus on 10/19/2025

Fixes: #20399

This PR introduces two boolean filters on MACAddress — assigned and primary — to improve filtering capabilities across the UI, REST, and GraphQL. It also adds an is_primary as a boolean column on the MAC Address table for quick visual scanning.

Summary of Changes

FilterSet (REST/UI):
- Add assigned (true ⇒ MACs bound to any Interface/VMInterface; false ⇒ unassigned).
- Add primary (true ⇒ MACs set as the primary MAC on any Interface/VMInterface; false ⇒ all others).
GraphQL:
- Wire the above filters into the GraphQL filter class to maintain parity with REST/UI.
UI / Tables:
- Add is_primary as a boolean column on the MAC Address table.
Forms:
- Expose the new boolean filters in the MAC Address filter form.
Tests:
- Unit tests for both assigned and primary filters (true/false cases).

API Examples

REST

GET /api/dcim/mac-addresses/?assigned=true
GET /api/dcim/mac-addresses/?primary=false

GraphQL

query {
  mac_address_list(filters: { assigned: true, primary: true }) {
    id
    mac_address
  }
}

Backward Compatibility

Additive change only; no existing behavior is altered.
No database migrations.

Implementation Notes

The table’s is_primary column is backed by a cached property to avoid repeated lookups while browsing tables.

Naming Notes

These filters are currently named assigned and primary to match existing boolean filter conventions. If the project prefers is_assigned / is_primary, I’m happy to adjust.

Happy to take any naming or scope adjustments the maintainers prefer. Thanks for the review!

*Originally created by @pheus on 10/19/2025*  ### Fixes: #20399  This PR introduces two boolean filters on `MACAddress` — **`assigned`** and **`primary`** — to improve filtering capabilities across the UI, REST, and GraphQL. It also adds an `is_primary` as a boolean column on the MAC Address table for quick visual scanning. ### Summary of Changes - **FilterSet (REST/UI):** - Add `assigned` (true ⇒ MACs bound to any `Interface`/`VMInterface`; false ⇒ unassigned). - Add `primary` (true ⇒ MACs set as the *primary* MAC on any `Interface`/`VMInterface`; false ⇒ all others). - **GraphQL:** - Wire the above filters into the GraphQL filter class to maintain parity with REST/UI. - **UI / Tables:** - Add `is_primary` as a boolean column on the MAC Address table. - **Forms:** - Expose the new boolean filters in the MAC Address filter form. - **Tests:** - Unit tests for both `assigned` and `primary` filters (true/false cases). ### API Examples **REST** ```text GET /api/dcim/mac-addresses/?assigned=true GET /api/dcim/mac-addresses/?primary=false ``` **GraphQL** ```graphql query { mac_address_list(filters: { assigned: true, primary: true }) { id mac_address } } ``` ### Backward Compatibility - Additive change only; no existing behavior is altered. - No database migrations. ### Implementation Notes - The table’s `is_primary` column is backed by a cached property to avoid repeated lookups while browsing tables. --- ### Naming Notes These filters are currently named `assigned` and `primary` to match existing boolean filter conventions. If the project prefers `is_assigned` / `is_primary`, I’m happy to adjust. Happy to take any naming or scope adjustments the maintainers prefer. Thanks for the review!

MrUnknownDE closed this issue

2026-04-05 19:56:27 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#1031

Closes #20399: Add assigned and primary filters for MACAddress #1031