VR SCSS rework and themes #1487

New Issue

MrUnknownDE · 2026-04-05T17:49:48+02:00

MrUnknownDE commented

2026-04-05 17:49:48 +02:00

Originally created by @N3X15 on 9/15/2020

I haven't tested this in VR yet, beyond making sure it doesn't crash. Will do that this afternoon after the thunderstorms die off.

This PR does a complete overhaul of the VR notification SCSS, making it use more features of SCSS and using them to make two themes: light and dark. I've also added some JS to (hopefully) permit switching between the two after reading the user's app settings.

[rant]

I'm going to be honest here, and please bear in mind that I'm not trying to disparage the developers: The UI for this application is great, but the way it's put together is highly inefficient and redundant. I have half a mind to do a more thorough overhaul to clean things up and get rid of a lot of dead code and redundancies. One particular example is uuidv4(), which is actually available in the uuid package pulled in as a dependency (node_modules/uuid/v4.js). The way uuidv4() is implemented right now is incorrect and insecure. On top of this, there's a lot of polyfills that we don't actually need for Chromium-based applications.

[/rant]

*Originally created by @N3X15 on 9/15/2020* **I haven't tested this in VR yet**, beyond making sure it doesn't crash. Will do that this afternoon after the thunderstorms die off. This PR does a complete overhaul of the VR notification SCSS, making it use more features of SCSS and using them to make two themes: light and dark. I've also added some JS to (hopefully) permit switching between the two after reading the user's app settings. [rant]<br /> I'm going to be honest here, and please bear in mind that I'm not trying to disparage the developers: The UI for this application is great, but the way it's put together is highly inefficient and redundant. I have half a mind to do a more thorough overhaul to clean things up and get rid of a lot of dead code and redundancies. One particular example is `uuidv4()`, which is actually available in the `uuid` package pulled in as a dependency (`node_modules/uuid/v4.js`). The way `uuidv4()` is implemented right now is incorrect and insecure. On top of this, there's a lot of polyfills that we don't actually need for Chromium-based applications. <br />[/rant]

MrUnknownDE closed this issue

2026-04-05 17:49:48 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/VRCX#1487