Rework WebApi.cs to use HttpClient #125

New Issue

MrUnknownDE · 2026-04-05T16:16:11+02:00

MrUnknownDE commented

2026-04-05 16:16:11 +02:00

Originally created by @LucHeart on 1/17/2026

Reworked WebApi.cs to use mode HttpClient instead of WebRequest. This solves various TLS issues.

Also made some fixes to GA, code signing now doesnt run when secrets are not configured. This makes it so Forks can still run Actions. Maybe we should include a warning artifact that no code signing has been done so we dont accidentally have non working code signing for release builds? Just as a safe guard.

PS: I probably wasnt able to test everything, if possible we should test this in nightly before going to stable.

*Originally created by @LucHeart on 1/17/2026* Reworked WebApi.cs to use mode HttpClient instead of WebRequest. This solves various TLS issues. Also made some fixes to GA, code signing now doesnt run when secrets are not configured. This makes it so Forks can still run Actions. Maybe we should include a warning artifact that no code signing has been done so we dont accidentally have non working code signing for release builds? Just as a safe guard. PS: I probably wasnt able to test everything, if possible we should test this in nightly before going to stable.

MrUnknownDE closed this issue

2026-04-05 16:16:11 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/VRCX#125