Fix floor clip bug #4

New Issue

MrUnknownDE · 2026-04-05T17:53:27+02:00

MrUnknownDE commented

2026-04-05 17:53:27 +02:00

Originally created by @Stermere on 3/29/2026

This PR fixes a bug that would cause floor-clip to not re-engage when the user returned to an upright pose from any pose where the hip was close enough to the floor to trigger the isStanding function to return false.

The logic that was removed here served to prevent any jumps in position as floor-clip was turning back on; however, in the current version of floor-clip, the currentDisengagementOffset variable also serves to prevent jumps in position, making the former logic redundant besides the below scenario

One potential downside of this is that there will always be a hard floor when using floor-clip, which means going down stairs or other vertical activities requiring the user to descend below their initial calibration position will behave unexpectedly. I feel this is an acceptable trade-off given a typical VR user's play space. This downside can be fixed with some changes to how currentDisengagementOffset is calculated.

*Originally created by @Stermere on 3/29/2026* This PR fixes a bug that would cause floor-clip to not re-engage when the user returned to an upright pose from any pose where the hip was close enough to the floor to trigger the `isStanding` function to return false. The logic that was removed here served to prevent any jumps in position as floor-clip was turning back on; however, in the current version of floor-clip, the `currentDisengagementOffset` variable also serves to prevent jumps in position, making the former logic redundant besides the below scenario One potential downside of this is that there will always be a hard floor when using floor-clip, which means going down stairs or other vertical activities requiring the user to descend below their initial calibration position will behave unexpectedly. I feel this is an acceptable trade-off given a typical VR user's play space. This downside can be fixed with some changes to how `currentDisengagementOffset` is calculated.

MrUnknownDE added the Type: Bug Area: Skeletal Model Area: Server Area: Server Area: Server labels 2026-04-05 17:53:28 +02:00

Sign in to join this conversation.

Branches Tags

main

aed/grammar-police

battery-0

bscotch/server-rewrite-temp

hannah/steam

pontoon

hannah/keybinds

server-rewrite

bscotch/accel-mount

dependabot/github_actions/gradle/actions-6

dependabot/github_actions/pnpm/action-setup-5

dependabot/github_actions/actions/upload-artifact-7

dependabot/github_actions/actions/download-artifact-8

FloorClipSteamLinkInteractionFix

sapphire/trim-vrm-json

llelievr/trackers-udp-tests

sapphire/linux-bridge-kotlin

sapphire/linux-vrchat-compatdata-path

smol-sleep-state

sapphire/stay-aligned-setup-no-step-skip

sapphire/steamvr-hands-warning

sapphire/proportions-import-skeleton-request

sapphire/bone-mask-update

llelievr/settings-profiles

bscotch/proguard

bscotch/bvh-fix

mitten

bscotch/reset-proof-tests

hannah/install-from-server

smol-buttons

TheButlah-patch-1

sapphire/update-solarxr

sapphire/kotlin-flatbuffers

csv-data-export

feat_flashmode

bscotch/remove-drift-compensation

llelievr/kotlin-config

bscotch/fix-osc-duplication

llelievr/keep-battery-value

rest-calibration-support

tracker-graph

fingertracking

update-eslint

tauri-android

hide-new-resets

height-config

snap-serial

feat/new-updater

support-inches

vrc-fix-ik-key

llelievr/3dmodel-preview

accel-mapping-fixes

llelievr/manual-proportions-rework

llelievr/put-automatic-steamvr-tracker-assigment-first

llelievr/remove-manual-mounting-onboarding

onboarding-usage-step

oldflex

motion-compensation

kotlin-warnings-fix

accessories

tpose

foxvr

No Label Area: Server Area: Server Area: Server Area: Skeletal Model Type: Bug

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/SlimeVR-Server#4