Simplify reset code (again) #207

New Issue

MrUnknownDE · 2026-04-05T18:05:50+02:00

MrUnknownDE commented

2026-04-05 18:05:50 +02:00

Originally created by @ButterscotchV on 10/24/2025

Our current reset code is a mess, we can absolutely annihilate gyroFix and leave it to yawFix to handle the yaw offset. The yaw calculation for isolating attachment pitch/roll is now using YXZ euler angle order so that roll does not affect the yaw (at the sacrifice of pitch, but it's one I'm willing to make). This also fixes changes to manual mounting orientation causing your calibration to be annihilated.

I tested this lightly and it works for IMUs, unsure about with HMD or computed trackers. I left most other jank the same because I don't want to break things, but there is a lot that can be improved. Notably, the way we handle computed trackers (which btw only means that it doesn't need mounting) is kinda weird and tposeDownFix is super weird and jank?

I would also like to make more unit tests, I spent way too much time figuring out all the logic behind the reset code so I'm prepared to actually write some new ones for computed trackers and maybe things like t-pose.

Replaces #1321

*Originally created by @ButterscotchV on 10/24/2025* Our current reset code is a mess, we can absolutely annihilate `gyroFix` and leave it to `yawFix` to handle the yaw offset. The yaw calculation for isolating attachment pitch/roll is now using YXZ euler angle order so that roll does not affect the yaw (at the sacrifice of pitch, but it's one I'm willing to make). This also fixes changes to manual mounting orientation causing your calibration to be annihilated. I tested this lightly and it works for IMUs, unsure about with HMD or computed trackers. I left most other jank the same because I don't want to break things, but there is a lot that can be improved. Notably, the way we handle computed trackers (which btw only means that it doesn't need mounting) is kinda weird and `tposeDownFix` is super weird and jank? I would also like to make more unit tests, I spent *way* too much time figuring out all the logic behind the reset code so I'm prepared to actually write some new ones for computed trackers and maybe things like t-pose. Replaces #1321

MrUnknownDE closed this issue

2026-04-05 18:05:50 +02:00

Sign in to join this conversation.

Branches Tags

main

aed/grammar-police

battery-0

bscotch/server-rewrite-temp

hannah/steam

pontoon

hannah/keybinds

server-rewrite

bscotch/accel-mount

dependabot/github_actions/gradle/actions-6

dependabot/github_actions/pnpm/action-setup-5

dependabot/github_actions/actions/upload-artifact-7

dependabot/github_actions/actions/download-artifact-8

FloorClipSteamLinkInteractionFix

sapphire/trim-vrm-json

llelievr/trackers-udp-tests

sapphire/linux-bridge-kotlin

sapphire/linux-vrchat-compatdata-path

smol-sleep-state

sapphire/stay-aligned-setup-no-step-skip

sapphire/steamvr-hands-warning

sapphire/proportions-import-skeleton-request

sapphire/bone-mask-update

llelievr/settings-profiles

bscotch/proguard

bscotch/bvh-fix

mitten

bscotch/reset-proof-tests

hannah/install-from-server

smol-buttons

TheButlah-patch-1

sapphire/update-solarxr

sapphire/kotlin-flatbuffers

csv-data-export

feat_flashmode

bscotch/remove-drift-compensation

llelievr/kotlin-config

bscotch/fix-osc-duplication

llelievr/keep-battery-value

rest-calibration-support

tracker-graph

fingertracking

update-eslint

tauri-android

hide-new-resets

height-config

snap-serial

feat/new-updater

support-inches

vrc-fix-ik-key

llelievr/3dmodel-preview

accel-mapping-fixes

llelievr/manual-proportions-rework

llelievr/put-automatic-steamvr-tracker-assigment-first

llelievr/remove-manual-mounting-onboarding

onboarding-usage-step

oldflex

motion-compensation

kotlin-warnings-fix

accessories

tpose

foxvr

No Label Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Area: Server Priority: Normal Priority: Normal Priority: Normal Priority: Normal Priority: Normal Priority: Normal Priority: Normal Priority: Normal Priority: Normal Priority: Normal Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Bug Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement Type: Enhancement

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/SlimeVR-Server#207