WIP fix sacrificial layer.cpp #93

New Issue

MrUnknownDE · 2026-04-05T16:18:25+02:00

MrUnknownDE commented

2026-04-05 16:18:25 +02:00

Originally created by @RF47 on 3/29/2026

Fix sacrificial layer edgecase , with 2 perimeters only

Adjusts the sacrificial bridge layer (“counterbore hole bridging”) geometry handling to address an edge case where walls disappear when only 2 perimeters are present
Is no longer needed a modifier to proper bridge detection.

Known issues (see comments below)
the one perimeter case is not adressed.

root cause:
When there are only two perimeters, this filter consumes the entire ExPolygon, which is why the bridges are not generated

f72de427cb/src/libslic3r/PerimeterGenerator.cpp (L1714-L1715)

Screenshots/Recordings/Graphs

Before:

After:

Tests

test sacrificial layer.zip

Fix #12953

*Originally created by @RF47 on 3/29/2026* # Fix sacrificial layer edgecase , with 2 perimeters only Adjusts the sacrificial bridge layer (“counterbore hole bridging”) geometry handling to address an edge case where walls disappear when only 2 perimeters are present Is no longer needed a modifier to proper bridge detection. Known issues (see comments below) the one perimeter case is not adressed. root cause: When there are only two perimeters, this filter consumes the entire ExPolygon, which is why the bridges are not generated https://github.com/OrcaSlicer/OrcaSlicer/blob/f72de427cb4920285fa7b4f3e6e4e5e7f7b6dddc/src/libslic3r/PerimeterGenerator.cpp#L1714-L1715 # Screenshots/Recordings/Graphs Before: <img width="1188" height="985" alt="image" src="https://github.com/user-attachments/assets/cd927360-2b15-4a79-8d55-991f415b0b49" /> <img width="1047" height="1001" alt="image" src="https://github.com/user-attachments/assets/73fa2131-624e-4900-bf6b-4fa5f8da2b66" /> After: <img width="1203" height="909" alt="image" src="https://github.com/user-attachments/assets/6e584eba-612e-4421-ad63-245fdae176c6" /> <img width="1093" height="850" alt="image" src="https://github.com/user-attachments/assets/7476f653-a7a9-439d-aabd-33df84d71932" /> <img width="1057" height="1061" alt="image" src="https://github.com/user-attachments/assets/d6dd600d-158e-47d5-b11f-25875ed829bb" /> ## Tests [test sacrificial layer.zip](https://github.com/user-attachments/files/26335429/test.sacrificial.layer.zip) Fix #12953

MrUnknownDE added the bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix labels 2026-04-05 16:18:25 +02:00

Sign in to join this conversation.

No Label bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#93