Enable filament picker UI for all OrcaFilamentLibrary manufacturers (#12163) #786

New Issue

MrUnknownDE · 2026-04-05T16:31:04+02:00

MrUnknownDE commented

2026-04-05 16:31:04 +02:00

Originally created by @zhanglinqian on 2/14/2026

OrcaSlicer Issue #12163 - Filament Selection UI Improvements

Summary

This change extends the filament picker UI to support all filament manufacturers in the OrcaFilamentLibrary, not just Bambu (BBL) filaments.

Problem

Previously, the FilamentPickerDialog only worked for Bambu filaments because:

It only loaded color data from BBL/filament/filaments_color_codes.json
The UI logic explicitly checked for "Bambu" prefix before showing the picker dialog
Other manufacturers (Overture, Polymaker, eSUN, etc.) fell back to the default system color picker

Solution

1. Created OrcaFilamentLibrary Color Codes File

File: resources/profiles/OrcaFilamentLibrary/filament/filaments_color_codes.json

Created a new color codes database following the same structure as BBL's file
Added sample colors for popular manufacturers:
- PolyLite PLA (Polymaker) - filament_id: OGFL00
- eSUN PLA+ - filament_id: OGFL03
- Overture PLA - filament_id: OGFL04
Included basic colors: White, Black, Red, Blue, Green, Yellow, Orange, Grey, Purple, Pink
Supports bilingual color names (English and Chinese)
Designed to be extensible - can add more colors and manufacturers as needed

2. Modified FilamentColorCodeQuery to Load from OrcaFilamentLibrary

File: src/slic3r/GUI/EncodedFilament.cpp

Changes:

Added #include <boost/filesystem.hpp> for path checking
Modified FilamentColorCodeQuery::FilamentColorCodeQuery() constructor to:
- First attempt to load from OrcaFilamentLibrary/filament/filaments_color_codes.json
- Fallback to BBL/filament/filaments_color_codes.json if not found
- Gracefully handle cases where neither file exists
This ensures backward compatibility while enabling new functionality

3. Updated PresetComboBoxes to Enable Picker for All Official Filaments

File: src/slic3r/GUI/PresetComboBoxes.cpp

Changes:

Removed Bambu-specific check: boost::algorithm::starts_with(fila_type, "Bambu")
Changed logic to check if filament has a valid filament_id (which all official filaments in OrcaFilamentLibrary have)
Restructured code to retrieve filament_id earlier and use it for both the check and dialog creation
This enables FilamentPickerDialog for all official filaments from any manufacturer

Impact

Benefits

Unified UI Experience: All filament manufacturers now have the same professional color picker UI
Better Color Accuracy: Manufacturers can provide specific color codes for their filaments
Scalability: Easy to add more colors and manufacturers by updating the JSON file
Backward Compatibility: Existing BBL filaments continue to work as before
Extensible: Structure supports future addition of more manufacturers

Manufacturers Supported

Currently supports color picker for:

Bambu Lab (all BBL filaments - existing)
Polymaker (PolyLite PLA, and others when colors are added)
eSUN (PLA+, and others when colors are added)
Overture (PLA, and others when colors are added)
AliZ
COEX
Elas
Eolas Prints
FDplast
FusRock
NIT
Numakers
SUNLU
Valment
Plus all Generic filament types

Adding More Colors

To add colors for additional manufacturers:

Get the filament_id from the manufacturer's base.json file
Add color entries to filaments_color_codes.json in the following format:

{
    "fila_color_code": "unique_code",
    "fila_id": "filament_id_from_base_json",
    "fila_color_type": "单色",
    "fila_type": "Manufacturer Filament Type",
    "fila_color_name": {
        "en": "English Name",
        "zh": "中文名称"
    },
    "fila_color": [
        "#RRGGBBAA"
    ]
}

Testing

Manual Testing Steps

Select a filament from a non-Bambu manufacturer (e.g., Overture PLA)
Click the color picker button
Verify that the FilamentPickerDialog opens (not the default system color picker)
Select a color from the grid
Verify the color is applied correctly
Test with Bambu filaments to ensure backward compatibility

Expected Behavior

OrcaFilamentLibrary filaments: Show FilamentPickerDialog with manufacturer-specific colors
BBL filaments: Continue to work as before (backward compatible)
Custom/User filaments: Fall back to default system color picker

Future Enhancements

Color Data Expansion: Add more colors for all manufacturers based on their official color catalogs
Gradient and Multi-Color Support: Add gradient and multi-color filament definitions
Auto-Generation: Create a tool to automatically extract colors from manufacturer data
Community Contributions: Allow community members to submit color codes for their filaments

Files Modified

src/slic3r/GUI/EncodedFilament.cpp - Updated to load from OrcaFilamentLibrary
src/slic3r/GUI/PresetComboBoxes.cpp - Updated to enable picker for all official filaments
resources/profiles/OrcaFilamentLibrary/filament/filaments_color_codes.json - NEW FILE

Backward Compatibility

✅ All existing BBL filament functionality is preserved
✅ Existing user configurations are not affected
✅ The change is additive, not breaking

Issue #12162: OrcaFilamentLibrary structure improvements
Issue #12163: Filament selection UI improvements (this issue)

*Originally created by @zhanglinqian on 2/14/2026* # OrcaSlicer Issue #12163 - Filament Selection UI Improvements ## Summary This change extends the filament picker UI to support all filament manufacturers in the OrcaFilamentLibrary, not just Bambu (BBL) filaments. ## Problem Previously, the FilamentPickerDialog only worked for Bambu filaments because: 1. It only loaded color data from `BBL/filament/filaments_color_codes.json` 2. The UI logic explicitly checked for "Bambu" prefix before showing the picker dialog 3. Other manufacturers (Overture, Polymaker, eSUN, etc.) fell back to the default system color picker ## Solution ### 1. Created OrcaFilamentLibrary Color Codes File **File:** `resources/profiles/OrcaFilamentLibrary/filament/filaments_color_codes.json` - Created a new color codes database following the same structure as BBL's file - Added sample colors for popular manufacturers: - PolyLite PLA (Polymaker) - filament_id: OGFL00 - eSUN PLA+ - filament_id: OGFL03 - Overture PLA - filament_id: OGFL04 - Included basic colors: White, Black, Red, Blue, Green, Yellow, Orange, Grey, Purple, Pink - Supports bilingual color names (English and Chinese) - Designed to be extensible - can add more colors and manufacturers as needed ### 2. Modified FilamentColorCodeQuery to Load from OrcaFilamentLibrary **File:** `src/slic3r/GUI/EncodedFilament.cpp` **Changes:** - Added `#include <boost/filesystem.hpp>` for path checking - Modified `FilamentColorCodeQuery::FilamentColorCodeQuery()` constructor to: - First attempt to load from `OrcaFilamentLibrary/filament/filaments_color_codes.json` - Fallback to `BBL/filament/filaments_color_codes.json` if not found - Gracefully handle cases where neither file exists - This ensures backward compatibility while enabling new functionality ### 3. Updated PresetComboBoxes to Enable Picker for All Official Filaments **File:** `src/slic3r/GUI/PresetComboBoxes.cpp` **Changes:** - Removed Bambu-specific check: `boost::algorithm::starts_with(fila_type, "Bambu")` - Changed logic to check if filament has a valid `filament_id` (which all official filaments in OrcaFilamentLibrary have) - Restructured code to retrieve filament_id earlier and use it for both the check and dialog creation - This enables FilamentPickerDialog for all official filaments from any manufacturer ## Impact ### Benefits 1. **Unified UI Experience**: All filament manufacturers now have the same professional color picker UI 2. **Better Color Accuracy**: Manufacturers can provide specific color codes for their filaments 3. **Scalability**: Easy to add more colors and manufacturers by updating the JSON file 4. **Backward Compatibility**: Existing BBL filaments continue to work as before 5. **Extensible**: Structure supports future addition of more manufacturers ### Manufacturers Supported Currently supports color picker for: - **Bambu Lab** (all BBL filaments - existing) - **Polymaker** (PolyLite PLA, and others when colors are added) - **eSUN** (PLA+, and others when colors are added) - **Overture** (PLA, and others when colors are added) - **AliZ** - **COEX** - **Elas** - **Eolas Prints** - **FDplast** - **FusRock** - **NIT** - **Numakers** - **SUNLU** - **Valment** - Plus all Generic filament types ### Adding More Colors To add colors for additional manufacturers: 1. Get the `filament_id` from the manufacturer's base.json file 2. Add color entries to `filaments_color_codes.json` in the following format: ```json { "fila_color_code": "unique_code", "fila_id": "filament_id_from_base_json", "fila_color_type": "单色", "fila_type": "Manufacturer Filament Type", "fila_color_name": { "en": "English Name", "zh": "中文名称" }, "fila_color": [ "#RRGGBBAA" ] } ``` ## Testing ### Manual Testing Steps 1. Select a filament from a non-Bambu manufacturer (e.g., Overture PLA) 2. Click the color picker button 3. Verify that the FilamentPickerDialog opens (not the default system color picker) 4. Select a color from the grid 5. Verify the color is applied correctly 6. Test with Bambu filaments to ensure backward compatibility ### Expected Behavior - OrcaFilamentLibrary filaments: Show FilamentPickerDialog with manufacturer-specific colors - BBL filaments: Continue to work as before (backward compatible) - Custom/User filaments: Fall back to default system color picker ## Future Enhancements 1. **Color Data Expansion**: Add more colors for all manufacturers based on their official color catalogs 2. **Gradient and Multi-Color Support**: Add gradient and multi-color filament definitions 3. **Auto-Generation**: Create a tool to automatically extract colors from manufacturer data 4. **Community Contributions**: Allow community members to submit color codes for their filaments ## Files Modified 1. `src/slic3r/GUI/EncodedFilament.cpp` - Updated to load from OrcaFilamentLibrary 2. `src/slic3r/GUI/PresetComboBoxes.cpp` - Updated to enable picker for all official filaments 3. `resources/profiles/OrcaFilamentLibrary/filament/filaments_color_codes.json` - NEW FILE ## Backward Compatibility ✅ All existing BBL filament functionality is preserved ✅ Existing user configurations are not affected ✅ The change is additive, not breaking ## Related Issues - Issue #12162: OrcaFilamentLibrary structure improvements - Issue #12163: Filament selection UI improvements (this issue)

MrUnknownDE closed this issue

2026-04-05 16:31:04 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#786