Fix filament override changes not appearing in Unsaved Changes and showing as “Undef category” in preset comparison #762

New Issue

MrUnknownDE · 2026-04-05T16:29:11+02:00

MrUnknownDE commented

2026-04-05 16:29:11 +02:00

Originally created by @kisslorand on 2/14/2026

Bug description

Changes made via filament overrides were not handled correctly:

Modified filament override settings did not appear in the Unsaved Changes dialog.
In the Compare Presets dialog, these changes appeared under
“Undef category / Undef group” instead of their proper category.

This made filament override edits:

Hard to detect
Confusing in preset comparison
Inconsistent with other preset types

Cause of the bugs

Two issues contributed to this behavior:

Deep comparison was not enabled for Print and Filament presets, so some override-related changes were not detected as dirty.
Option lookup for certain keys failed to resolve proper metadata, triggering a temporary fallback that displayed them as
“Undef category / Undef group”.

Changes in this PR

Enable deep comparison for Print and Filament presets in both:
- UnsavedChangesDialog
- DiffPresetDialog
Improve option lookup to resolve metadata correctly.

The result

Filament override changes now correctly appear in Unsaved Changes.
Preset comparison displays them under their proper category.
No more misleading “Undef category” rows.
Behavior is now consistent across preset types.

By accident I realized that this PR also fixes #11970.

Screenshots

Before:

After:

Before:

After:

*Originally created by @kisslorand on 2/14/2026* ### Bug description Changes made via **filament overrides** were not handled correctly: - Modified filament override settings **did not appear** in the Unsaved Changes dialog. - In the Compare Presets dialog, these changes appeared under “**Undef category / Undef group**” instead of their proper category. This made filament override edits: - Hard to detect - Confusing in preset comparison - Inconsistent with other preset types ### Cause of the bugs Two issues contributed to this behavior: 1. **Deep comparison was not enabled for Print and Filament presets**, so some override-related changes were not detected as dirty. 2. Option lookup for certain keys failed to resolve proper metadata, triggering a temporary fallback that displayed them as “Undef category / Undef group”. ### Changes in this PR - Enable deep comparison for **Print** and **Filament** presets in both: - UnsavedChangesDialog - DiffPresetDialog - Improve option lookup to resolve metadata correctly. ### The result - Filament override changes now correctly appear in Unsaved Changes. - Preset comparison displays them under their proper category. - No more misleading “Undef category” rows. - Behavior is now consistent across preset types. By accident I realized that **this PR also fixes #11970**. ### Screenshots - **Before:** <img width="902" height="977" alt="image" src="https://github.com/user-attachments/assets/6427a858-f30b-4749-b25f-0ab437c55de7" /> - **After:** <img width="902" height="977" alt="image" src="https://github.com/user-attachments/assets/5ed98cb1-1336-4459-90f6-c76503d28946" /> - **Before:** <img width="1252" height="1217" alt="image" src="https://github.com/user-attachments/assets/75c0d97f-2caa-4949-b2f8-cb649a23a760" /> - **After:** <img width="1252" height="1044" alt="image" src="https://github.com/user-attachments/assets/9f52832f-aefa-4f06-9e37-0f981a850216" />

MrUnknownDE closed this issue

2026-04-05 16:29:11 +02:00

Sign in to join this conversation.

No Label bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#762